From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id EEE333858C52 for ; Sun, 23 Oct 2022 15:13:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEE333858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 8DDDE341184; Sun, 23 Oct 2022 15:13:29 +0000 (UTC) Date: Sun, 23 Oct 2022 19:44:03 +0545 From: Mike Frysinger To: Tsukasa OI Cc: Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org Subject: Re: [PATCH 02/40] sim: Check known getrusage declaration existence Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+0Cdqk90rFN9evCh" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --+0Cdqk90rFN9evCh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20 Oct 2022 09:32, Tsukasa OI wrote: > Clang generates a warning if there is a function declaration/definition > with zero arguments. Such declarations/definitions without a prototype (an > argument list) are deprecated forms of indefinite arguments > ("-Wdeprecated-non-prototype"). On the default configuration, it causes a > build failure (unless "--disable-werror" is specified). >=20 > Such getrusage function declarations are placed in three files under sim/= ppc > and to avoid defining those on the modern environments, this commit will > make the configuration script to find the known declaration of getrusage > and defines HAVE_DECL_GETRUSAGE if it finds one. >=20 > If we find one (and we *will* in most modern environments), we don't need > to rely on the deprecated declarations. > --- > sim/config.h.in | 4 ++++ > sim/configure | 32 ++++++++++++++++++++++++++++++++ > sim/configure.ac | 10 ++++++++++ > 3 files changed, 46 insertions(+) you didn't actually fix the bad prototypes in the ppc code -- just delete t= hem. pretty sure once you do, you won't need any of these changes. -mike --+0Cdqk90rFN9evCh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVSKcACgkQQWM7n+g3 9YHR5xAAiTflbL9oPuDl1L3wEeCN9yHhj/gQd/E/OjeySh1276YqPzI1UbcPOyvh H089cZj3Div2LEJ2oQT3kcuoAGOh2tVD2kDYDQcNMCnszQp257WYnMy3ib0jv0Bw Vjh4xQjGgMbCLRpJ6YBYDgGOuIfAl7m7OunRiIiAB55salzFUIGhoaFqmccsKzC8 6Tn5fz+nw7NvnJ4AlT0eH+jaCkPRwoUFNIVuHf7frr739QIEKyZ9+TN9TxMlc3o6 YF9bY/RWJOuOseEWlXeFHspBteMaqkMTKXTtD90sUlCmkwRol7jn/h38MVejccyu o/x2NOzFnCrb8ZLTSf8FWUHU7TL5rOzbUZlTys3UymrIlvd5XaUqryYyzTwVql0k CclHYLO7LqyYENhNRE2idIXqj0nV5xIseh0ivajOWNja6W/dL7iPiqichHGRoU30 20F4ZkCApSXPmk8jgYvIUOpSUyiRi0bqEM6X3BYdFooQhIVUttmyXgGGmrMC/3zA 5zCeU3192vJsiki/H1br6GpE2ctWrN9hkabfWekN4bmVGoHX5Xj+hc6PpjsWn2ef ktmhytsKlEJoIvvsZ07P5ayrlmHLCs/dcjtAmw2VELFiN9r5gbtwP9MjJRUgwdhL BaJCyQAKjCoh30TMk+gZ2XcSO6wYq4+stUkflB3+siKCgFIdByA= =xSkU -----END PGP SIGNATURE----- --+0Cdqk90rFN9evCh--