On 20 Oct 2022 09:32, Tsukasa OI wrote:
> Clang generates a warning if there is a redundant self-assignment
> ("-Wself-assign").  On the default configuration, it causes a build failure
> (unless "--disable-werror" is specified).
> 
> However, removing self-assignments in step_once function makes the code less
> readable.  Instead, this commit inserts dummy addition to match the comments
> "Value added == 0".  This is redundant but will suppress warnings and
> matches with other branches better.  It will be also optimized away so we
> can ignore performance impact on this.
> ---
>  sim/h8300/compile.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/sim/h8300/compile.c
> +++ b/sim/h8300/compile.c
> @@ -4141,7 +4141,7 @@ step_once (SIM_DESC sd, SIM_CPU *cpu)
>  	  res = GET_B_REG (code->src.reg);	/* FIXME fetch? */
>  	  if (!c && (0 <= (res >>  4) && (res >>  4) <= 9) && 
>  	      !h && (0 <= (res & 0xf) && (res & 0xf) <= 9))
> -	    res = res;		/* Value added == 0.  */
> +	    res = res + 0x0;		/* Value added == 0.  */

Andrew posted a patch to just delete the assignment.  either is fine with me.
-mike