On 19 Oct 2022 16:24, Andrew Burgess via Gdb-patches wrote:
> When building the cris, m32c, and sh simulators with Clang I am seeing
> build warnings from a few objects.  These three simulators currently
> build with -Werror, and so these warnings cause the build to fail.
> 
> When built with gcc I don't see any warnings from these targets, so
> the -Werror is fine.
> 
> As the warnings are not new, in this commit, I propose that we disable
> the use of -Werror for these three simulators.  With this done it is
> now possible to build the complete simulator tree using clang.

sory, but i don't understand the logic here.  the code builds cleanly with gcc
which is why we have -Werror enabled.  but when building with clang, you see
errors, so you want to disable -Werror for gcc and allow new issues to slip in
to the tree ?

this change/approach looks wrong to me.  if the tree is clean with gcc, leave
it to people interested in clang to figure it out w/out making the situation
worse for GNU users.  this is the GNU sim, not the LLVM sim.
-mike