From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 290E83858D28 for ; Sun, 23 Oct 2022 15:31:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 290E83858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id CABB9341191; Sun, 23 Oct 2022 15:31:37 +0000 (UTC) Date: Sun, 23 Oct 2022 20:02:11 +0545 From: Mike Frysinger To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 10/10] sim/cris/m32c/sh: disable use of -Werror Message-ID: Mail-Followup-To: Andrew Burgess , gdb-patches@sourceware.org References: <42c09bcd56bb7bf0a84d58ffad71894f284b5401.1666192979.git.aburgess@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hpYc6Zg5RItnWA+S" Content-Disposition: inline In-Reply-To: <42c09bcd56bb7bf0a84d58ffad71894f284b5401.1666192979.git.aburgess@redhat.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --hpYc6Zg5RItnWA+S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 19 Oct 2022 16:24, Andrew Burgess via Gdb-patches wrote: > When building the cris, m32c, and sh simulators with Clang I am seeing > build warnings from a few objects. These three simulators currently > build with -Werror, and so these warnings cause the build to fail. >=20 > When built with gcc I don't see any warnings from these targets, so > the -Werror is fine. >=20 > As the warnings are not new, in this commit, I propose that we disable > the use of -Werror for these three simulators. With this done it is > now possible to build the complete simulator tree using clang. sory, but i don't understand the logic here. the code builds cleanly with = gcc which is why we have -Werror enabled. but when building with clang, you see errors, so you want to disable -Werror for gcc and allow new issues to slip= in to the tree ? this change/approach looks wrong to me. if the tree is clean with gcc, lea= ve it to people interested in clang to figure it out w/out making the situation worse for GNU users. this is the GNU sim, not the LLVM sim. -mike --hpYc6Zg5RItnWA+S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVTOcACgkQQWM7n+g3 9YGOtw/9EFtwd8C+X9pdlhzeRb3IVyPef7rh/YUbOrysKotCrPUh0HmP8SuuPMA4 oGRRtyDJunThuwc7H0NMBNdlqqMSIdrILsvuEBjVQf+3KudhNmH5hVOvotqHvm0p 0oqF1FRFV32H2w4j0ojRLL4ny+hOpOIHKVebp/ekwRdaRimeVdZe0Ga7xk/vWDGm +fds4gjbhhHg7aQfsemGFLL+8YixxZKGHHDBKTYheyvk3/02ECzehoT0EQs1fgVP 6nvq4zWo/LqIGfaz70NEEVDUa66g7nS/4JvG5KU8YH3BfFmikCc02CTviwwJKeQK z346tJOyCwNmYxMHpWCND1bTdhRr8mUBM5b9oKiZct6aj+aSejT9c7gZSaFRr/LW yVyvBfJ7qaHKWzEJikBpzzO76pu0Mxubd2uGjYRNm7As6gZH3uNBJzDAz0qRKcDN YeCpv6n2NFO4O7KGadtUqo914+Zal5VOMiS6eCdf9iBjGT5LS5KeXvDJoC2ciRIj 7EyJ6xJ4vS2DThHdPAD9fwrxcAB5aye0qKX2QIRBt/6OtTMGxmCvnZj8k0+EeEpn 7rJQyeobiqxVXLJS8mbiDLOZY1ZN3si7an+UAr1IwrtScE6tpS/0oWSeEQW7ELnV SABKhUUlJhswH6cqKgDsOFlpaU661mIjDAAxUTHxgAES9JCQ0Eo= =V7ZQ -----END PGP SIGNATURE----- --hpYc6Zg5RItnWA+S--