From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id D67073858D28 for ; Sun, 23 Oct 2022 15:47:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D67073858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 717A734117F; Sun, 23 Oct 2022 15:47:15 +0000 (UTC) Date: Sun, 23 Oct 2022 20:17:49 +0545 From: Mike Frysinger To: Tsukasa OI Cc: Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org Subject: Re: [PATCH 09/40] sim/erc32: Use int32_t as event callback argument Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: <057c2f8392410494c3bc5dc98052246508e6a73e.1666258361.git.research_trasio@irq.a4lg.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FxvJYgAfqT92kn+S" Content-Disposition: inline In-Reply-To: <057c2f8392410494c3bc5dc98052246508e6a73e.1666258361.git.research_trasio@irq.a4lg.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --FxvJYgAfqT92kn+S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20 Oct 2022 09:32, Tsukasa OI wrote: > Clang generates a warning if an argument is passed to a function without > prototype (zero arguments, even without (void)). Such calls are deprecat= ed > forms of indefinite arguments passing ("-Wdeprecated-non-prototype"). > On the default configuration, it causes a build failure (unless > "--disable-werror" is specified). >=20 > To fix that, this commit makes struct evcell to use int32_t as a callback > (cfunc) argument of an event. would help to mention that int32_t was picked because that's what some parts of the event/callback code is already using. > --- > sim/erc32/erc32.c | 28 ++++++++++++++-------------- > sim/erc32/func.c | 8 ++++---- > sim/erc32/sis.h | 4 ++-- > 3 files changed, 20 insertions(+), 20 deletions(-) README.sis needs updating. otherwise looks OK. -mike --FxvJYgAfqT92kn+S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVUJEACgkQQWM7n+g3 9YEBWBAAy/pOS3Nv+N9XjHQykJsjj7qN/OGskKO93VtT1gE/m4gBYlEgwP8tR3+r ML235jBJLIw/vnyN8dPLtMhv2+qSC6jE95PmXfVEIDvnjbZL7gGVSP7G6/6kQXH7 suQ6jRK67sgzHn+yqzGZwoJZhhpTtQIVM6Vldy7kWdk7CnT+XC5Evioi2LmP1taL 3nCY09f73/1VDDMKf1SzorF9NiJVdZW0zzHv6atwXay1s+HgyZ1g8LHYbxdWgBME S8n0jw9OE8XwFIny6pAXaPTdF05guNGJQpbMLil0Hvlc4oaIgbvTUczkO9HcZZH/ KFZ9SHgcVQ4fbJban1c+ZxgtD8PiePVv/hNQkgaAZ9os7qQO6yX53wV9vOBPGzlo p+TOqAGbEWushMzGhr54HC1yCz/JKuubS0EsNcVTM2VDvce4xhtNeS2PF0vXIa90 dMBYWrlJjKfZABRLrFwBG1w1BnmJU3dD6nqC/ZXWka5TKCZ9VwhTiciiIyG9mSYG LY0QsC9b49cFMnrzMUhwZdizUmc7UwcUP/VFAWxs/1jWTQ20dh9cXwxGUdBXw8ai 1TCRTpN8yq1ODRa5gsgz2MwC0SHbpRxSX5nfrbzbg53saa+JxLL+9gtv1yAVpKjW mSYYAQ9ta1kq0TdjCF2AoSDmvj65X8mYaB2zaGaraNud7vX6J/o= =VjYu -----END PGP SIGNATURE----- --FxvJYgAfqT92kn+S--