On 20 Oct 2022 09:32, Tsukasa OI wrote: > GCC generates a warning if a variable may be used uninitialized on some > cases ("-Wmaybe-uninitialized"). Despite that GCC will not cause a build > failure even when "--enable-werror" is specified, it would be nice to get > rid of it. > > This commit initializes the variable nesr when declared. afaict, the code as written is not using nesr uninitialized (well, it does, but not in a way that changes behavior in the func, or is exposed out). so this looks fine because setting it to 0 initially in those cases also does not change behavior. i'm not familiar enough with FRV to say if pulling nesr from a diff place would be more safe to future code refactors. but since this port seems to largely be stable at this point, this is probably fine. -mike