From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 66AC93858D1E for ; Sun, 23 Oct 2022 15:55:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 66AC93858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 9622C340B10; Sun, 23 Oct 2022 15:55:13 +0000 (UTC) Date: Sun, 23 Oct 2022 20:25:47 +0545 From: Mike Frysinger To: Tsukasa OI Cc: Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org Subject: Re: [PATCH 14/40] sim/frv: Add explicit casts Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Dn1YFWq03Ptoc5Xf" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Dn1YFWq03Ptoc5Xf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20 Oct 2022 09:32, Tsukasa OI wrote: > Clang generates a warning if there is an enum value with a mismatching ty= pe > without an explicit cast ("-Wenum-conversion"). > On the default configuration, it causes a build failure > (unless "--disable-werror" is specified). >=20 > This commit adds explicit casts on the FR-V instruction decoder. >=20 > Note: > This commit touches CGEN-generated files directly. > Modifying CGEN is the best way to prevent this issue from happening again > but there is another known regression in CGEN to resolve. i don't know what regression you're referring to, but if the CGEN output do= es this now, that's fine. but if CGEN doesn't do this, we should get that fix= ed first, or make sure the fix is in progress, not just reported. -mike --Dn1YFWq03Ptoc5Xf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVUm8ACgkQQWM7n+g3 9YF26hAAsVk2sI3qlyI3CZraMCqQ5znrQL/5DtGEasKYmnyD51vvSwQN0jMKFC1s 9TNnFsMdNYavVzPPOg1LgOiVANhccV366Bvuc98WfVYGTsvWSVS4hunklZQeOz9o J8C9IG3dSEs62znOErcz0yN8ZT7Yewh4EbxDrsgRaYO/Eo7+s9APGrYF3u6X07v9 PBFush8LHog0r/BJaOMR+cXCe+vjST+CUX0mCc1ZCaPSsWUrRPrPDP1UYCnkLYJX FvTocJW5rQwbigiawwqGIiLkPjWAavRrMGYV+WyhRd4H44nVOqpBGUG2HI38oFiy V8GU8UAi5WjaHQ1LU74fUMRv6Iio6bZEW0ruXlXunG2W8thUPuNy8byo3JATumL4 CI3vJ4r5tXfihD0ptc0qJD31BIOw5vl3l6TCEeiGoY72Qf+ds9esfRudqVOE7XSv FZziLbzXDrhCgQIJZt/ajdOUEwzw3lsImys9IAPOAv7wLDcDPYZqMHmxCN4W/Y1m p36scnyhvpmi23mJtF5LcbrHDBO4GeQEk9ACiXLjqd27wBq3itALD1h2KVLnx7t/ TRrpeIrWWfm+pQT/uk0c67oCaqaP+SNotg+j7N/nqG6D2GICH9Hp9sz6+hgHknj+ zDA6Cc6p8po/qmQg8fjf/BuGx/Dpuc6UJobCCCgXm4wW94DgcrY= =aH7m -----END PGP SIGNATURE----- --Dn1YFWq03Ptoc5Xf--