From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	by sourceware.org (Postfix) with ESMTP id 8E79E3858D28
	for <gdb-patches@sourceware.org>; Sun, 23 Oct 2022 15:56:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E79E3858D28
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
Received: by smtp.gentoo.org (Postfix, from userid 559)
	id 2EB41340CD2; Sun, 23 Oct 2022 15:56:31 +0000 (UTC)
Date: Sun, 23 Oct 2022 20:27:05 +0545
From: Mike Frysinger <vapier@gentoo.org>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Andrew Burgess <aburgess@redhat.com>, Nick Clifton <nickc@redhat.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH 17/40] sim/lm32: Add explicit casts
Message-ID: <Y1VSvSjPPqvNNkRp@vapier>
Mail-Followup-To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Andrew Burgess <aburgess@redhat.com>,
	Nick Clifton <nickc@redhat.com>, gdb-patches@sourceware.org
References: <cover.1666258361.git.research_trasio@irq.a4lg.com>
 <e094b1379231d9ffb59a78cfebbcc84634c779c6.1666258361.git.research_trasio@irq.a4lg.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="TjbbGI4dD/uf13E3"
Content-Disposition: inline
In-Reply-To: <e094b1379231d9ffb59a78cfebbcc84634c779c6.1666258361.git.research_trasio@irq.a4lg.com>
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>


--TjbbGI4dD/uf13E3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 20 Oct 2022 09:32, Tsukasa OI wrote:
> Clang generates a warning if there is an enum value with a mismatching ty=
pe
> without an explicit cast ("-Wenum-conversion").
> On the default configuration, it causes a build failure
> (unless "--disable-werror" is specified).
>=20
> This commit adds explicit casts on the LatticeMico32 instruction decoder.
>=20
> Note:
> This commit touches CGEN-generated files directly.
> Modifying CGEN is the best way to prevent this issue from happening again
> but there is another known regression in CGEN or sim/lm32 to resolve.

same feedback as what i said in "[PATCH 14/40] sim/frv: Add explicit casts"
-mike

--TjbbGI4dD/uf13E3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVUr0ACgkQQWM7n+g3
9YFM2hAApEomofJekQHDDkaC9eLlxlxkGOska2oakhA2vy4dgIeZ4nKE78L/fDFz
E/fZWHRXXo9j5Rp056WkC1ZBxhx8S2NjIQkpFyNTrf75PXSz7hMkEqQc/2ZfqDB9
pkjFNhQ9PWJz+vnDefS7CQ+itZrth7clW+be1wIFd8eXQHzs4j8ASaEFjJbGvxnp
FuJV3gJS6rL7sEqiOGg6Tdsct+rtZVPmR5ewb4bE4kQHSEogX3ZhThvd/h7aMVYR
Sv/JAe4ipol2p2cQPA/ty2lPFFFlEjL8vO9+DHeI/GxCTrdfT6pnGgJg87lpxaqF
Q1rgkIArUcn7axkyd0X3zmLXf+BWN9nTxv94AfoOdTKqHFltTKd59VIZQR3r8q9q
UmQ60gUEEnWqvG1sexhJUtJXBKOYxtAtZA2C2t9fFZweuupOLmlxQm4UzrfJSBfE
JiMCFS8ehamjZh5P3EnreiDeQzPoP34/b7u9at5bWh87hAomJ8O3yFD2yRPAxPPE
1zVGHm7x7j/VOBA+dzO6id/Qvx8rFzo5BHsiM7+nr3N9jdXvCGyC1t8kbKPLMDe6
KjSSOOjdT4Z5NVQtH+JjsF2assugVl6+5R1uTL+S9uBJ5N6ZWuy/vlnA9ms3M5o6
3ffND2mmo+0Rl+FlAjIABHjUgXcfl/Qz2MmNNzp/hykUlBXhFIo=
=8wGA
-----END PGP SIGNATURE-----

--TjbbGI4dD/uf13E3--