On 20 Oct 2022 09:32, Tsukasa OI wrote:
> The led_off array used 0xB7 (Latin-1 middle dot) but it heavily depends on
> the source code encoding.  Directly using 0xB7 here is very dangerous and

"very dangerous" is questionable

> Clang causes a compiler warning ("-Winvalid-source-encoding").
> On the other hand, using '\u00b7' here will assume UTF-8.

we only care about UTF-8.  no other encoding (except ASCII) matters.

> As a workaround, this commit replaces uses of 0xB7 with '.'
> (regular ASCII dot).

i don't have a sense of what this code is meant to do.  is it just debug
output for devs staring at the console ?  probably because of the CSI
escape sequences here (\e[m).  if that's the case, i'm fine with changing
it.  i'll note that the RX port seems to use @ & * instead ...
-mike