From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id B7D3E3858D28 for ; Sun, 23 Oct 2022 16:02:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B7D3E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 658B6341186; Sun, 23 Oct 2022 16:02:36 +0000 (UTC) Date: Sun, 23 Oct 2022 20:33:10 +0545 From: Mike Frysinger To: Tsukasa OI Cc: Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org Subject: Re: [PATCH 18/40] sim/m32c: Stop using middle dot Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FmvWLhzyxw12wF9u" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --FmvWLhzyxw12wF9u Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 20 Oct 2022 09:32, Tsukasa OI wrote: > The led_off array used 0xB7 (Latin-1 middle dot) but it heavily depends on > the source code encoding. Directly using 0xB7 here is very dangerous and "very dangerous" is questionable > Clang causes a compiler warning ("-Winvalid-source-encoding"). > On the other hand, using '\u00b7' here will assume UTF-8. we only care about UTF-8. no other encoding (except ASCII) matters. > As a workaround, this commit replaces uses of 0xB7 with '.' > (regular ASCII dot). i don't have a sense of what this code is meant to do. is it just debug output for devs staring at the console ? probably because of the CSI escape sequences here (\e[m). if that's the case, i'm fine with changing it. i'll note that the RX port seems to use @ & * instead ... -mike --FmvWLhzyxw12wF9u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVVCoACgkQQWM7n+g3 9YHwnQ//RuGLLA+7DDEAol2mnW0K33pmALLe+0pmfIRQbYGzZL25NW1Ev1Wj+1rK ibwGGKs+pWEjXvTJPKePpXHbY16nW+/6s1WMgCxtmUAU4d/XsYD7qQGvmSuCYS5a FEeYBGzGZt5GNbO9gRybLEhcby4VwXquKUjvU89zcenBWNPgYdwxnG8Manq9CiYF M6sSFcUnYWfL0AmeGBexBJHideYlUEsoOz26cGtBQsiP6skQU/RiOaO6FqZhZbgc 51k56+mBmA3xR+7AmZ/7kzOSThtOGvALwYOZa6tvEIxSzzRpSMczDlxmY+MYSUTr NB70g9FjKfb8jgP9n+CRjw21j32RzWnla3fWwucgsext5HUxT2SP93YsZOvPwP3E NW3RTSEzB/kbIt2UBFFA33KSm/S3CcI6Rs70bVTwv77WXHk2KPy0bpqDl0tcqnDl 9fsdsBN5iv6URQ3J8RpfS5XJaiEJ45AoY4zeSEKd2J5ux8I5qJZHLu6L97OP9534 /9ZuyIZwVordCwQ5+IKFWGBU+Tn3oEwsN6d1TIN+DLQk9qZRPfNY/Tj4W9XiTkgl KpWNIXK1SRiXVLSSOvLgzZ7xsn+jnDW2XjU2p6BC0IxSt3aY2qbRU6ms6TND1oyP 2JRaNXEKeY8i8w7Y4zvLmQphfgwfUVa4V1Tv4TKdjlXPUZRK9d8= =THd/ -----END PGP SIGNATURE----- --FmvWLhzyxw12wF9u--