From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	by sourceware.org (Postfix) with ESMTP id AB6BA3857831
	for <gdb-patches@sourceware.org>; Sun, 23 Oct 2022 16:08:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AB6BA3857831
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
Received: by smtp.gentoo.org (Postfix, from userid 559)
	id 553ED34106B; Sun, 23 Oct 2022 16:08:02 +0000 (UTC)
Date: Sun, 23 Oct 2022 20:38:36 +0545
From: Mike Frysinger <vapier@gentoo.org>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Andrew Burgess <aburgess@redhat.com>, Nick Clifton <nickc@redhat.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH 20/40] sim/m32r: Prepare required functions
Message-ID: <Y1VVcG2oKhM5laNt@vapier>
Mail-Followup-To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Andrew Burgess <aburgess@redhat.com>,
	Nick Clifton <nickc@redhat.com>, gdb-patches@sourceware.org
References: <cover.1666258361.git.research_trasio@irq.a4lg.com>
 <c08bf674f03e0fd8433319335bb90336e1b1c57b.1666258361.git.research_trasio@irq.a4lg.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="9FG0WwdhG0H/DxHz"
Content-Disposition: inline
In-Reply-To: <c08bf674f03e0fd8433319335bb90336e1b1c57b.1666258361.git.research_trasio@irq.a4lg.com>
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>


--9FG0WwdhG0H/DxHz
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 20 Oct 2022 09:32, Tsukasa OI wrote:
> This commit includes necessary header files and creates duplicated
> declarations from other header files.
>=20
> Duplicated declarations are necessary on M32R because, despite that some
> m32rbf functions are used by m32rx and m32r2, we cannot include two or mo=
re
> CPU header files: "cpu.h", "cpux.h" and "cpu2.h".

move/duplicate prototypes in a common header (e.g. m32r-sim.h) that both pl=
aces
will include, never put them into a C file itself.  as written, there is no
protection keeping the prototypes in sync.
-mike

--9FG0WwdhG0H/DxHz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVVXAACgkQQWM7n+g3
9YF0fxAAz5nxlQ2sTa1ZPEx2hzyIpIC/TiGNlLXWks047bLKClu+WtQaEclclFQL
BPba519MxelSF74eNyq5zZeFuBOiGLvDv+wwHsoFmFxjwdLf6tXtWELQHmVdK0qH
1+jJrDRnUlaN6A5Qz1k3QX5PRnDV2DntgZ9M7IOlq1N+kxerpU/b06g0neHY1VTO
o5/ueofcGb7SsT4suX1rhoA4kHZX3Q4ASVO0XcbZM4tcXdzNRyIWnih2WiWUo6Gp
fy6u8yBpzhmYCaGw6ZD8RbHiWDJnxLYUKos0cVIwsJIIxnlVTcX0O0I090GOJN5U
PMoDleiDz80Q5jN9r4w15ZW0FsyBSaaImcNaoIOBhUXRoVlr6R7iyOmMTaDaURq+
GyEHwYBM/zaN2arx/VwgLlS6ansJn7y2n6POboabynCwchNJkU2kdsxLXVhUX2M/
XiFVq1BxKosGiyYMdpUMa/h68ayi8r0mtCm2DOvAUnC4RQbzGM8r3QKgswsHVQV5
hXkt5IfFr4yCkPuDJs7gSVY85qxoOyuKd5wrqEW/ylaW+d8lbz6jTh5027NbpapL
IAjlQG57WLPy6/2gwfu00MJQOrKoH1KEYjgSxKmrOUC4OT+0hGKfUwGIF4B34Yne
W3/xZ6bOp78plt2fyZebBujMmRi4qb8MIenen+TYK5BD2jBUwY8=
=tEro
-----END PGP SIGNATURE-----

--9FG0WwdhG0H/DxHz--