From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	by sourceware.org (Postfix) with ESMTP id 7E2413858280
	for <gdb-patches@sourceware.org>; Sun, 23 Oct 2022 16:11:23 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E2413858280
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
Received: by smtp.gentoo.org (Postfix, from userid 559)
	id 3084E34106B; Sun, 23 Oct 2022 16:11:23 +0000 (UTC)
Date: Sun, 23 Oct 2022 20:41:57 +0545
From: Mike Frysinger <vapier@gentoo.org>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Andrew Burgess <aburgess@redhat.com>, Nick Clifton <nickc@redhat.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH 22/40] sim/m32r: Fixes to Linux emulator
Message-ID: <Y1VWOXxLeSC/uzkf@vapier>
Mail-Followup-To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Andrew Burgess <aburgess@redhat.com>,
	Nick Clifton <nickc@redhat.com>, gdb-patches@sourceware.org
References: <cover.1666258361.git.research_trasio@irq.a4lg.com>
 <a3693e7a058878c5a64f39ce0e58c7a2605b3a07.1666258361.git.research_trasio@irq.a4lg.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="MX1cv4gnxiQev3u9"
Content-Disposition: inline
In-Reply-To: <a3693e7a058878c5a64f39ce0e58c7a2605b3a07.1666258361.git.research_trasio@irq.a4lg.com>
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>


--MX1cv4gnxiQev3u9
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On 20 Oct 2022 09:32, Tsukasa OI wrote:
> 1.  Some header files were missing

this looks fine

> 2.  syslog function must be called as a syscall rather than POSIX syslog
>     because we are emulating Linux system calls on the Linux host.

i don't think that is accurate.  if that were true, every other call in here
would be using syscall() instead of calling the C library functions.

> 3.  ftime function is deprecated but used intentionally.
>     We have to disable deprecated function warning.

this looks fine
-mike

--MX1cv4gnxiQev3u9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVVjkACgkQQWM7n+g3
9YGj0BAAzvTtNJcrEzJYHI8FE33TplC7Ikm1UWeAhl1wVpeU/uJmbHONUAzLzq3k
WJNS09RU3aDlVHSCaTrk1rGLCczSQVn7e1cpk80fthVjfnXIS8lM7Cl+x3qDUe1t
IaayampcMNtcpaGv3d376pBvOtL7zIb/V6enIaYGoUReThUsqbSlqKMRp9oumEHw
6NFaYdb43jkhPwrGMJ+smwDhw1xmLHDHzu6E0Wv3vvXeinmkAlzjCPQ+jwuo83U0
Zm6O+1xSb7xK0sOHluNGoB2DOVr+u3fRJqp+rhuTWASX9dMdObcXhEdFrBJkLLKD
3DQ9+NKMOpc4iwAKZ1pezd1YcJ6mrg4QmTlIM5d91xcSoRr9Pse8rTu1ygMjr3Ma
mip6lTivPDD/TETtmSdjRcW4ci+ym6UT/OsyKZWzHSsWrDJcztLyE7EMyJxKDc4j
ngN9xf3kxLEER2KL9okQ5Tt25APbLDxeaoJ1h6nP+MdMweFZ3tuTkpxcDpewQaQ/
Swhy2aUNZCGMNRvfoIs8hvKw3ixjOxRXl1NcdYV5pws7svEe4pgvkekczT0te5ye
+VbMgw/mO8sh+BTww4rp62zRH2/FC9HTwOuIBT827ax55QKheAeYhdDqx5VxbGS+
gXCM0M/8zXdd59VzfQT2hkiXpeecgG9dJhTKBLPRAABs9fb0CjA=
=ySko
-----END PGP SIGNATURE-----

--MX1cv4gnxiQev3u9--