From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 49B6F3858404 for ; Sun, 23 Oct 2022 16:11:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49B6F3858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id ECD2C34107F; Sun, 23 Oct 2022 16:11:58 +0000 (UTC) Date: Sun, 23 Oct 2022 20:42:33 +0545 From: Mike Frysinger To: Tsukasa OI Cc: Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org Subject: Re: [PATCH 23/40] sim/m32r: Add explicit casts Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sNXmHDMgt/COxg/F" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --sNXmHDMgt/COxg/F Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20 Oct 2022 09:32, Tsukasa OI wrote: > Clang generates a warning if there is an enum value with a mismatching ty= pe > without an explicit cast ("-Wenum-conversion"). > On the default configuration, it causes a build failure > (unless "--disable-werror" is specified). >=20 > This commit adds explicit casts on the M32R instruction decoder. >=20 > Note: > This commit touches CGEN-generated files directly. > Modifying CGEN is the best way to prevent this issue from happening again > but there is another known regression in CGEN or sim/m32r to resolve. same feedback as what i posted to "[PATCH 14/40] sim/frv: Add explicit cast= s" -mike --sNXmHDMgt/COxg/F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVVl0ACgkQQWM7n+g3 9YENJQ//VSR3ZO0L37Gj158hKUy115MfUXYnZTzHxHXxj0ltGvlHmJ14CVnBV1W1 7ejsDMz1jYOHTqT3ZF4ICYjWFejYj6AtEDjcj12Hvj/GVk3CbdttnZSBA8J0EZRq CWsm8GZXgJv59wnCAmu0+kUU3dQNE7/25dtFT23J7vR4Y8vdf1SHWqBbqdH/aCOc FQq/7YwTBvkejF4v/CrQJMfdnpdqv5T9WWa4bSf2JpOGailfRec+Rwri0gpPalyL Zuw/DKEmkYT4zXXipyeYBvE++eRcNORlqd7ULofiHrT+R/XHNW5lILYdZfeI8vTv ActHkNsKNOhQXxFuGXSqZf10Sw4RRpM9umbBHGeFKHEO2g2w656e/M2zeUv/wOlY fouOYmi8kDdhED0JvfcY0oo8cLd3uK9ItomUHpVfwNwJmfB3fQgWh6sqlqoteseF e33mj6EWApZxHlhfDTwMPNi9MJN/J5AMKxEgEyrM4qr19q43/E6kNZtc+QRjnbnu vgj9hvYSDO0qydqghHWwWZmZsfnrSYPHBcc7hHZCwlir/GXNt4T8ugEqvW0b2GED 2aHuf3dqim9wEfm/2mDwwps386ktJeYMwAwNZO3pQIFBzzeGJyEiPCC5CnReqMfD O6BNlCZXJSZhwMxQgE6h8DkOOPWjQwCEHH6dxxlUdMNoYAJgH4o= =x3HV -----END PGP SIGNATURE----- --sNXmHDMgt/COxg/F--