From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 52BAE3858D39 for ; Sun, 23 Oct 2022 16:15:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52BAE3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 07266340D5A; Sun, 23 Oct 2022 16:15:21 +0000 (UTC) Date: Sun, 23 Oct 2022 20:45:55 +0545 From: Mike Frysinger To: Tsukasa OI Cc: Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org Subject: Re: [PATCH 24/40] sim/mips: Fix enum type-related issues on cp1.c Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZR5iAiFuKXAfe8LP" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --ZR5iAiFuKXAfe8LP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 20 Oct 2022 09:32, Tsukasa OI wrote: > --- a/sim/mips/cp1.c > +++ b/sim/mips/cp1.c > @@ -1178,7 +1178,7 @@ inner_rsqrt(uint64_t op1, > uint32_t res; > sim_fpu_32to (&wop1, op1); > status |= sim_fpu_sqrt (&ans, &wop1); > - status |= sim_fpu_round_32 (&ans, status, round); > + status |= sim_fpu_round_32 (&ans, (sim_fpu_round) status, (sim_fpu_denorm) round); this doesn't look correct at all. are you sure about this ? > @@ -1216,7 +1216,7 @@ fp_inv_sqrt(sim_cpu *cpu, > FP_formats fmt) > { > sim_fpu_round round = rounding_mode (GETRM()); > - sim_fpu_round denorm = denorm_mode (cpu); > + sim_fpu_denorm denorm = denorm_mode (cpu); this looks fine > @@ -1903,8 +1903,8 @@ convert_ps (sim_cpu *cpu, > case fmt_ps: > - status_u |= sim_fpu_round_32 (&wop_u, 0, round); > - status_l |= sim_fpu_round_32 (&wop_l, 0, round); > + status_u |= sim_fpu_round_32 (&wop_u, 0, (sim_fpu_denorm) round); > + status_l |= sim_fpu_round_32 (&wop_l, 0, (sim_fpu_denorm) round); this also looks wrong -mike --ZR5iAiFuKXAfe8LP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVVycACgkQQWM7n+g3 9YE93xAA3c9adrN9/i2rHxWeugq17NGjRhlRo0jql/wfCrm/yfJ74TMvizZIY92q nXlsUsDqWzX7ouh/LbRRq62xrhBV4u5BTpUmyJKM5TuMNg7YcOL26iI4dI6LbGfo j1LAKqr8wdqmuMzTLKR/sIWmLqojgjZAjuQ4+f0QkDB9iVBpD3texg5va4He5AHP 8DHFFsK1i3OiY1+kWO/6SsObN54vgGt675JuXCG1qKx1cbQENf50tK2tAzSa7Vdk QdKg9B5slBmH0wGVZU4O0rNR2ArK6Y6yvgFwf+c3DQVzOBEbTSc5YJRz6b2PGEV9 bcB6hHExqtrqrG1iHcWrLOx8gOQN22+WIjPwGA6liDFtjzvqx+CnnLN83o3fscm4 78PNp9agpjakpMSVruvDaiGXVVSVgH7Kt4SoenNtyzM5MzrMMG2acP45jRdF1eVV Utskhq/9mZD/RKHCXaxmixxalzko2wpTBGUeFxtqgTNJE4aVvIHyhv9yaUx3gPGH I/STbE+3yI8P28vEQrsYXz3AMvAWsF1Tq3idNmEfHrygWOAAABwiCgbIZzXcRZVp rdgyWDfEN2JLCr8EUnfri2sGs2hYeNM8kLpiiV4BQ7s5gPjDNt2k5MCWQpPatF8v LoE/zkOl0VMGokkA9vE1ubkmgYSlQqGmHAbUhd/dM9lwavriFrw= =iALW -----END PGP SIGNATURE----- --ZR5iAiFuKXAfe8LP--