From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id C958B385355D for ; Sun, 23 Oct 2022 16:30:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C958B385355D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 7DF04340B9E; Sun, 23 Oct 2022 16:30:25 +0000 (UTC) Date: Sun, 23 Oct 2022 21:00:59 +0545 From: Mike Frysinger To: Tsukasa OI Cc: Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org Subject: Re: [PATCH 38/40] sim/bpf: Add explicit casts Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: <6e5213e625e6c309f2baaae5e6a3dad20155e696.1666258361.git.research_trasio@irq.a4lg.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Vi6q3TLi6B/kdoSK" Content-Disposition: inline In-Reply-To: <6e5213e625e6c309f2baaae5e6a3dad20155e696.1666258361.git.research_trasio@irq.a4lg.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Vi6q3TLi6B/kdoSK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20 Oct 2022 09:32, Tsukasa OI wrote: > Clang generates a warning if there is an enum value with a mismatching ty= pe > without an explicit cast ("-Wenum-conversion"). > On the default configuration, it causes a build failure > (unless "--disable-werror" is specified). >=20 > This commit adds explicit casts on the BPF instruction decoder. >=20 > Note: > This commit touches CGEN-generated files directly. > Modifying CGEN is the best way to prevent this issue from happening again > but there is another known regression in CGEN to resolve. same feedback as what i posted to "[PATCH 14/40] sim/frv: Add explicit cast= s" -mike --Vi6q3TLi6B/kdoSK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVWq8ACgkQQWM7n+g3 9YFf2Q/8C5OigtDMoTbQf24SYalBbB+6VK6yX1CHGwW2DQAoefZSmUQkzt7gkuDB uucR1uToDSNaSaPbFdoJxakSG+FLoqOZU6HP1x2bkxUb+G6KcQtdcesmMdDANXSK Q3nbCHDXV2oUsGL6OMTAplTdXpUTYZqz1xcQs+iPG1UG1vti0Naz6NEkY3DTHwN5 n0AFbcPBF4IJB0QIebKIjuL179i0U50ZIkLKIsqvmtwuIByEkwCW2YT9fCXp+f0V r3iB/9gXg7krLtPx89cJ4yON+T7MROmUYLyT2HTERlkwYkQoxHOt1a2jl4yJZgA8 XQFvwK/5iIgYo1MS1WyiIqgqKLedqC01uNHIEqH+7x17GW6XqSj0DSOysbf0flll tbJeKM/CZ9/HXHPU+NMAvDK7ofsT/prL2fYdFF8QCUEoB8M93s/31vON188HYLmG oDHOaaKXxn4NK9V00DtCr6sCWcnrTPU98I7tgupbIqWRg39fYJkPqeVMGwNlCJjW HRKiC2QDAn+BsB4mJ/lPS9gtX0kdiZ1W4w6s6LHIwDd6HxIy/zh40yJC9xSGuU+p sGvvlGqpEjrAiTsIqueiuSTkJ9kNR5h4rU4EjwTD2ULO5b/uXSLQnkgpAyj88vET rh0V3yF5k9g6OIeCxDBvGIfssMssbZ3Ig96OLoDbDJYFI05RCEA= =FOru -----END PGP SIGNATURE----- --Vi6q3TLi6B/kdoSK--