From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	by sourceware.org (Postfix) with ESMTP id 16FDF3852742
	for <gdb-patches@sourceware.org>; Sun, 23 Oct 2022 16:30:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 16FDF3852742
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
Received: by smtp.gentoo.org (Postfix, from userid 559)
	id BD3FC34117C; Sun, 23 Oct 2022 16:30:36 +0000 (UTC)
Date: Sun, 23 Oct 2022 21:01:11 +0545
From: Mike Frysinger <vapier@gentoo.org>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Andrew Burgess <aburgess@redhat.com>, Nick Clifton <nickc@redhat.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH 39/40] sim/iq2000: Add explicit casts
Message-ID: <Y1Vau2cau0MdXJT9@vapier>
Mail-Followup-To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Andrew Burgess <aburgess@redhat.com>,
	Nick Clifton <nickc@redhat.com>, gdb-patches@sourceware.org
References: <cover.1666258361.git.research_trasio@irq.a4lg.com>
 <f81c5e7298963890a1dcea49b9ff37bed369240e.1666258361.git.research_trasio@irq.a4lg.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="YCI1pjtzQWtzKYsq"
Content-Disposition: inline
In-Reply-To: <f81c5e7298963890a1dcea49b9ff37bed369240e.1666258361.git.research_trasio@irq.a4lg.com>
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>


--YCI1pjtzQWtzKYsq
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 20 Oct 2022 09:32, Tsukasa OI wrote:
> Clang generates a warning if there is an enum value with a mismatching ty=
pe
> without an explicit cast ("-Wenum-conversion").
> On the default configuration, it causes a build failure
> (unless "--disable-werror" is specified).
>=20
> This commit adds explicit casts on the IQ2000 instruction decoder.
>=20
> Note:
> This commit touches CGEN-generated files directly.
> Modifying CGEN is the best way to prevent this issue from happening again
> but there is another known regression in CGEN or sim/iq2000 to resolve.

same feedback as what i posted to "[PATCH 14/40] sim/frv: Add explicit cast=
s"
-mike

--YCI1pjtzQWtzKYsq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVWroACgkQQWM7n+g3
9YEKiBAAss1DYnWi/LmRool4K+65P2Os4f3wlxhyiHn+9nifaaFk5jSQD7BcMB3G
COtXURZG865tect3/J69SHjghY8THkhnEb6kasA1zeaUD5r0nYsyXef89hYigY8K
i8WZCWx3XluRUEwM5jAvUeae8wIjFxQcERywyUB50GDFscvEFHnlDenfxjac/Mwa
faj8/qO1ly95emq6ZzijYvGTtMSg3GsJtProla6Id4zhVlhSpmaaaG8oUN38gn6W
bAE4USczKHUWibAbejLIFdX5fYEByugC6xdqDyHj3Q5BYHXN/99Ae6g4/Iiz2RVd
C6YqLx7uHfxBQzhuFIJfeFZHAJrzXjvoburx4EEmKWO+nbQ24uaTqlR1IoCaJqwt
qsaosDtVBMacCow/lH5Zv0ton2OgIvRQhvaYx8GVboG9D60WeMa0ol0IGQskF8pb
f+1u90fldpC0Y2j+URZb/RDCGqSa2n09S6BVdKSscLHtBngmK893xUBofxyukYJw
JovX31IIymxl3QtesYeIFSKAtboUsHUdsHQGG6DF5kDJAmBuc+nRdUTeBnQ66trY
IzRInmN+hJ94MxowMCwGEsCTAX+sZT1864+bz2pUeDoifL88EHjOHTnBHSLx7MgY
BAl/QXZw4Ll7oq1dnwXcXTt7Oh/jGCO1Z+UktwJ7wI0DpUcgsqw=
=eu9I
-----END PGP SIGNATURE-----

--YCI1pjtzQWtzKYsq--