From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 425AC3852770 for ; Sun, 23 Oct 2022 16:30:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 425AC3852770 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id D457F340CCF; Sun, 23 Oct 2022 16:30:45 +0000 (UTC) Date: Sun, 23 Oct 2022 21:01:20 +0545 From: Mike Frysinger To: Tsukasa OI Cc: Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org Subject: Re: [PATCH 40/40] sim/or1k: Add explicit casts Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: <0cefc89e745a41b15aa70da010ccce7bdb632ceb.1666258361.git.research_trasio@irq.a4lg.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="51V2+rWL4tV6fdYl" Content-Disposition: inline In-Reply-To: <0cefc89e745a41b15aa70da010ccce7bdb632ceb.1666258361.git.research_trasio@irq.a4lg.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --51V2+rWL4tV6fdYl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20 Oct 2022 09:32, Tsukasa OI wrote: > Clang generates a warning if there is an enum value with a mismatching ty= pe > without an explicit cast ("-Wenum-conversion"). > On the default configuration, it causes a build failure > (unless "--disable-werror" is specified). >=20 > This commit adds explicit casts on the OpenRISC 1000 instruction decoder. >=20 > Note: > This commit touches CGEN-generated files directly. > Modifying CGEN is the best way to prevent this issue from happening again > but there is another possible regression in CGEN to resolve. same feedback as what i posted to "[PATCH 14/40] sim/frv: Add explicit cast= s" -mike --51V2+rWL4tV6fdYl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVWsQACgkQQWM7n+g3 9YF7CRAA5Be2zCUOASZ1kokRmopoOe3Kl6ub8VCmM8wAGmygDMMRh7SOJ2TpydOS d9khTw4OTrd0aSvlIQfV9sutzVmp2XbUCmUgL8b6Xy5kJPy/sm47OmlNVT4vG1u6 9+nLYDzgZAM/oPymVnXI+h5O9dyLsZip1PNdDYekx7PY5X6X3lC80wcgB/R4SaqR NKcDdHHcevL34orF35iKD/1hHXYkspXVSTjsuJUIb6HOVuBmfeAR5mxImT62c3t8 kx1LYaMKEySAKjH5jph1DAUH9IPiphOaAqXJK9lp/91JTF/6D8pb0V+nOpZplwdl 9OgaZB70wibdz5oGNV8NDGLnHHtNyJBbaEPsSeWfOfXntLNEIAWEIqocNZ8/LXph 4eGpEdP64EnpPBb8YyBUDIIeadSz8ahMQOWgqF4M/9N5PicqXZPkgTPCe67bW+B2 zR7WoSaWQY4dlOa8/IvZcuu7NqXbEPrFV2INoXbz6aGy5dD+G4ISNGYQLlCPB0PU TBWqff/dibP/XnhzQNShkKT/CoqyI1DF/BkfVM7hGoRQOF0ZT/nhOsBhtidX18Ty JXcqslROI3HZKYtyA23nupfJ6k0JoVXyioazxWygBwbEWGf+Kt4aff1ob4GX44Yn 62XKIYtLMgy8YAUaXs8DoivIFNO5ZL5dbUe++vkdumhFBWek8o0= =TFRm -----END PGP SIGNATURE----- --51V2+rWL4tV6fdYl--