From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 730D0385702C for ; Sun, 23 Oct 2022 20:30:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 730D0385702C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 51C44340FA7; Sun, 23 Oct 2022 20:30:54 +0000 (UTC) Date: Mon, 24 Oct 2022 01:01:28 +0545 From: Mike Frysinger To: Tsukasa OI Cc: Andrew Burgess , Nelson Chu , Kito Cheng , gdb-patches@sourceware.org Subject: Re: [RESEND PATCH 0/1] sim/testsuite: Trim extra path from arch Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nelson Chu , Kito Cheng , gdb-patches@sourceware.org References: <28df7073ec5a8f601ba47c9d2f7d4a7a0ce08753.1657795051.git.research_trasio@irq.a4lg.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2KCrJLnSgjqN3/GH" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --2KCrJLnSgjqN3/GH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 27 Aug 2022 01:53, Tsukasa OI wrote: > The patch is a RESEND of > > but to the right mailing list and completely new cover letter. please clean up the patch and send it out standalone -- no need for a cover letter, and the relevant details should all be in the patch itself. > 1. Configure Binutils with aarch64-unknown-elf and build it > /src/binutils/configure \ > --target=aarch64-unknown-elf \ > --prefix=/opt/cross/aarch64-unknown-elf \ > --enable-multilib > && make > 2. Run `make check-sim' and confirmed that the simulator tests "pass" > 3. Intentionally try to fail the test by modifying > `sim/testsuite/aarch64/pass.s' > (replace the last line from "pass" to "fail") > 4. Run `make check-sim' and "confirmed" that the simulator tests "pass" since i don't have the same paths as you, i didn't run the same configure. but using --target=aarch64-elf and running `make check-sim` with -j1 vs -j4 doesn't show any behavior difference. all the tests are found & run. if i add an error to one of the tests like you did, it fails in both modes. $ runtest --version DejaGnu version 1.6.3 Expect version 5.45.4 Tcl version 8.6 > However, this block doesn't work because the `arch' variable returned by > the `sim_arch' function is "./aarch64". That is supposed to be "aarch64". i don't mind fixing sim_arch, but this really should be fixed too. we shouldn't be in a situation where "./aarch64" is present as an input. seems easy enough to do so i pushed a patch for it. -mike --2KCrJLnSgjqN3/GH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVkwwACgkQQWM7n+g3 9YFUTQ/+PZQBNDxLA1T+3YFvgaptg6agJq0s5Ht+Ax6rVyH+JuihkTReB6tQMwEi Ft6ZAclsuFtGnj9QvIeg25LgnkWYghy325kISybs2ue90MlLaNmi+7Fk1LPAFEMc kD6P+lA3BXYHoWTA1mE69IMjaBGCdg63DkC3c/P1QofWUdDchKaiWOlVgNrjkNw9 XJkAmcxHRjCI3GI5IZ9IFEDQJ1rb5KjtL0zhygVH+eYOFqyS17lX5ZIWma7yzAS/ RBPeLg2oUNA3l/hlQc5bDqfaqVgXtzEH9z6YzIEvUUYR0jUltR0mK6lJ2N35OcLD 18Al+Bv8IMLC6RWXRlPe4noDLClb+wKXx95+ydu5m+FMnPUhp3/yh2PupBBh3z6a qfRtp+sE+Juhd1yZn7OAfdGO3WzTcPxd21FmILCqSnNXOGv3SdLQuCVlnjILkCs5 CLtPqYVApHBAtcDnrNCjFZXiXL5754AHFy6xjZvvR8YuqM6SBT0BnyO2tkBIvKZO 5fvbSOEXohin3IXpBhGsZA2u0f2dBiQOpLcK3kqly9RhlRZvt8aOD6speopFLkwF SFXq97G5ynqSRXPTvjfjg5GvQSrhSKcqfqAlKxq4/K738WFgbgWuPSVki09MF3Dq sWsUf+DYhk1ggQhUj4vEbPKsNHUeQ0hR785HRhBpGN5sHZwXdq0= =36yJ -----END PGP SIGNATURE----- --2KCrJLnSgjqN3/GH--