From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 66A963858D35 for ; Thu, 12 Jan 2023 05:22:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66A963858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x334.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so10941676wma.1 for ; Wed, 11 Jan 2023 21:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xu1klNlmqn7OE6ZYohWeWD+HcFrAGH1wq2nLENOoYAc=; b=AKxLUq9xNdww/mKpBRrQ4lhmK3qV4ifo6R51ac33Xv4XPd2C61dp9FOkt7LMHrQelG URe0zu64ge57Br7yFc/XaKVuCQHa6lswGNyTvqyd+2LWryEbgyDC5e4xMHX3gQd8XbTI pPX+fZOHv1T56IponJ8jpfN1wi31ThqVZDBc2gG/gsT0Syq5KlKuOjUpFrgAaCLQQ3gi Mp4rpd2EVawRyXZkZLnK5G/kXOuSzqw5JZNUfZ/RRDFMfaBgrnetHoCM9aPpSeZNiyfN 1BKPMzWWDV/GixTQ31spQy21u5Ub3+W77C+9KQ4FFnUVHYHmgak29iSv/wNc8tgbfHrX yImA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xu1klNlmqn7OE6ZYohWeWD+HcFrAGH1wq2nLENOoYAc=; b=tB2XoblhLGS2MiVqlWArsW8t6yMyRqpChr5QbdzMjPvtwpupXC1tbfz9FiXZyOQZPb 6eAaSuWLZonerSITt8mu1gAF7HMkCyTQWe4F6s8X8SpzqJsPBsT0Ng9AaaX+lUuzTT/7 It0YFF1VmvrPhVGjQRSBgrCa/hA2mYQvjleyvY/uHfS+UevP9Jf6zFdPspO6xfQzf0mn U86vc6eSkrVsG817NaOxxsRWTRHbJpMRl1r420GqNXhFNgOOz7klL1q3jb16deaIGBzb M6suSIwGOj5zmL4duoE+pXX9DPM+JjJa2MukU8gCi9O4Gmf73ZYrqfyFVHUDAH23gk5o gT9g== X-Gm-Message-State: AFqh2kosS24dY75PeSnO6uHLM51wjD9tP9l2KONQCUnGiHqJd6x2Cg6m NEXnj03RKj5rE8G4JpLO2zes X-Google-Smtp-Source: AMrXdXu/duRp4nGhg35dfdMHvrsGIMoU8W2EjGaT6VULMSFy2s1DUqSODw167iKrJtEIXfBlrAWghw== X-Received: by 2002:a05:600c:34c4:b0:3d1:bf7c:391c with SMTP id d4-20020a05600c34c400b003d1bf7c391cmr58598810wmq.4.1673500971110; Wed, 11 Jan 2023 21:22:51 -0800 (PST) Received: from takamaka.gnat.com (lfbn-reu-1-488-54.w92-130.abo.wanadoo.fr. [92.130.77.54]) by smtp.gmail.com with ESMTPSA id h10-20020a05600c2caa00b003cfd58409desm26114177wmc.13.2023.01.11.21.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 21:22:50 -0800 (PST) Received: by takamaka.gnat.com (Postfix, from userid 1000) id A07C182890; Thu, 12 Jan 2023 09:22:48 +0400 (+04) Date: Thu, 12 Jan 2023 09:22:48 +0400 From: Joel Brobecker To: Tom Tromey Cc: Tom Tromey via Gdb-patches , Joel Brobecker Subject: Re: [PATCH] Set _WIN32_WINNT in common.m4 configure check Message-ID: References: <20230109144716.1988567-1-tromey@adacore.com> <87ilhd6kso.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ilhd6kso.fsf@tromey.com> X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, > Tom> GCC recently added support for the Windows thread model, enabling > Tom> libstdc++ to support Windows natively. However, this supporrt > Tom> requires a version of Windows later than the minimum version that is > Tom> supported by GDB. > > Tom> PR build/29966 points out that the GDB configure test for std::thread > Tom> does not work in this situation, because _WIN32_WINNT is not defined > Tom> in test program, and so seems to be fine. > > Tom> This patch is an attempt to fix the problem, by using the same setting > Tom> for _WIN32_WINNT at configure time as is used at build time. > > Tom> I don't have access to one of the older systems so I don't think I can > Tom> truly test this. I did do a mingw cross build, though. I'm going to > Tom> ask the bug reporter to test it. > > There turns out to also be some small problem in libstdc++ so this patch > can't fully be confirmed. However it also seems like an improvement, so > I am going to check it in. > > Joel, I tend to think we should consider this for GDB 13. Without it, > GDB 13 won't build with a newer GCC on some older Windows systems. Thanks for the heads up, Tom. Sounds good to me! -- Joel