From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id E9AA93858C50 for ; Sat, 14 Jan 2023 06:05:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9AA93858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x434.google.com with SMTP id b5so1667938wrn.0 for ; Fri, 13 Jan 2023 22:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YuaQWTrT5dOvRHSZatRAVL1lIPtcQ0rHZZb3H2LWAPg=; b=g7XfffX/OnujEVo98LJb4rfRQMy0uKjHKzr/oOeOwBFk8HaIb2oobQWqcEXRq9QVi3 84kS2qRJ4awNZ66nCtXmM1TSnAOSoTs3R8n9gM7qahy9vCZOgVUgSOdkovL5C9oiyIHQ ZT53bZUDsyA01qpD6Ps5gkYXSHQeQLfCDskOn5nacGvRwBydtebqjUrOn1i5tu9sQUhm xTEcWvK48sCbk9OrG3oliHFDnHVsqPCEdDgBAJzv7BgNE/A3ftL24VotCSP3ClAYTHQj z9bUIwYhA3/6iwH4zMH1uC4r87pKuVpP9fvMxzhBObuIYsOFXXeIyVYSGG/r+8BhNqh6 pWuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YuaQWTrT5dOvRHSZatRAVL1lIPtcQ0rHZZb3H2LWAPg=; b=Yb6ROX1MVpxYO+2qLg6XMJOIhJ0sm8aGPASCDLVnGKIxO0arZKfgSsY/1sVWhdCX2x LGIlAA5S33Hqx0vMcxmBEuXbBGDiiKuG9WpkKIzSwryN4C1CDefjg4WdFYSV0rMSZyws bJbk2vJZz2TsyRRkHFrrI6OUGduzL6XaIfzcxb3AbfBRM3nir+5232joDPR1pW/898Jl nprReaDiIQ4zi5W3G1/Qw9dHXaP8jkiIn9o90c7gJPm7S5BSZeCMESzlae3uehAHSKOc OR1WbFrWqf4XSBATaS53Rkyjw/cStoIcgV42hUV/7b3l261wK02YsXi4CJ1MAxPuCrh1 kojw== X-Gm-Message-State: AFqh2kp1PSYbesz37ZrXgq7quQvlEBxRNJotm46vJIIwubn/A30m4ln4 QFHMJhKfyYCR+iJbscbCY6+KRGkqkca76Aw= X-Google-Smtp-Source: AMrXdXscooYy4kO8030ZI3Y3fBVv1Mh2B/3R4ZDetHIBLpTkmnvJjznSqooLSnCaB6heg4tmeuOQFw== X-Received: by 2002:adf:ee4b:0:b0:2bd:bed5:9207 with SMTP id w11-20020adfee4b000000b002bdbed59207mr11473312wro.12.1673676323764; Fri, 13 Jan 2023 22:05:23 -0800 (PST) Received: from takamaka.gnat.com (lfbn-reu-1-488-54.w92-130.abo.wanadoo.fr. [92.130.77.54]) by smtp.gmail.com with ESMTPSA id w8-20020adf8bc8000000b002bdc39849d1sm8329736wra.44.2023.01.13.22.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 22:05:23 -0800 (PST) Received: by takamaka.gnat.com (Postfix, from userid 1000) id 2D2118219E; Sat, 14 Jan 2023 10:05:21 +0400 (+04) Date: Sat, 14 Jan 2023 10:05:21 +0400 From: Joel Brobecker To: Tom Tromey via Gdb-patches Cc: Tom Tromey , Joel Brobecker Subject: Re: [PATCH v2 2/4] Don't erase empty indices in DWARF reader Message-ID: References: <20230110183338.2623088-1-tromey@adacore.com> <20230110183338.2623088-3-tromey@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230110183338.2623088-3-tromey@adacore.com> X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jan 10, 2023 at 11:33:36AM -0700, Tom Tromey via Gdb-patches wrote: > The DWARF reader has some code to remove empty indices. However, I > think this code has been obsolete since some earlier changes to > parallel_for_each. This patch removes this code. I don't think this code needs a re-review, since it's already been approved by me, and I think also by Andrew, but just in case, OK for me :). > --- > gdb/dwarf2/read.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index 851852404eb..c3f246fedf7 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -7170,16 +7170,6 @@ dwarf2_build_psymtabs_hard (dwarf2_per_objfile *per_objfile) > print_tu_stats (per_objfile); > > indexes.push_back (index_storage.release ()); > - /* Remove any NULL entries. This might happen if parallel-for > - decides to throttle the number of threads that were used. */ > - indexes.erase > - (std::remove_if (indexes.begin (), > - indexes.end (), > - [] (const std::unique_ptr &entry) > - { > - return entry == nullptr; > - }), > - indexes.end ()); > indexes.shrink_to_fit (); > > cooked_index_vector *vec = new cooked_index_vector (std::move (indexes)); > -- > 2.38.1 > -- Joel