On 15 Jan 2023 00:28, Mark Wielaard wrote:
> signal.h isn't needed in microblaze and mn10300 interp.c
> so don't include it.

these changes are fine to merge if you want to split it out

> In common sim-events.c, sim-signal.c, nrun.c and dv-sockser.c we
> do need signal.h, but check whether REG_PC is defined (and then
> undefine it) before including the sim headers.
> 
> It breaks the build on sparc because signal.h indirectly
> includes /usr/include/sys/ucontext.h and defines REG_PC,
> which is also defined in microblaze-opcm.h

i don't think this is correct.  none of the files quoted use REG_PC,
so undefining a random symbol in them doesn't make sense.  nothing in
sim/common/ uses REG_PC for that matter.
-mike