From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 7D9703858D32 for ; Sun, 15 Jan 2023 00:22:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D9703858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id C8280340EDF; Sun, 15 Jan 2023 00:22:29 +0000 (UTC) Date: Sat, 14 Jan 2023 19:22:29 -0500 From: Mike Frysinger To: Mark Wielaard Cc: gdb-patches@sourceware.org, Sam James Subject: Re: [PATCH] sim: common, microblaze, mn10300: handle signal.h defining REC_PC. Message-ID: References: <20230114232805.827713-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XusqxpXOodgkJo6J" Content-Disposition: inline In-Reply-To: <20230114232805.827713-1-mark@klomp.org> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --XusqxpXOodgkJo6J Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 15 Jan 2023 00:28, Mark Wielaard wrote: > signal.h isn't needed in microblaze and mn10300 interp.c > so don't include it. these changes are fine to merge if you want to split it out > In common sim-events.c, sim-signal.c, nrun.c and dv-sockser.c we > do need signal.h, but check whether REG_PC is defined (and then > undefine it) before including the sim headers. >=20 > It breaks the build on sparc because signal.h indirectly > includes /usr/include/sys/ucontext.h and defines REG_PC, > which is also defined in microblaze-opcm.h i don't think this is correct. none of the files quoted use REG_PC, so undefining a random symbol in them doesn't make sense. nothing in sim/common/ uses REG_PC for that matter. -mike --XusqxpXOodgkJo6J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmPDR0UACgkQQWM7n+g3 9YHvOA/+Pzf/7eU0S/16z1A8pnjOOb3oE1TDvRy2v6jl5mNWWNtafbFmDFnje3eF jkIpaTcKyFZKBhACu3QoAKXagsofnhhRXi40j2hn74zVGs7FAO5D0A8awMQKrq15 wdBR0z5LvPldO6B8+Mn8lUIdrweb+ZV56Vwr6otUJq0vb36PKvV23pY1u66HYlUV FCYXNzwGZZsE+L5qPNWLoMth2jl+wyvnSbcQPk0Zf+F7l9AHeUF1aUV0gbNDqWs0 5z05ObJdRTlbFbzIsPebM2am3BMJSy8dNhi2/oHORV6IDbpKtKYvVYT1Phg+jnve ULBNnEFCN47tI1gpRnF8SemAl/L1f4Xvyy6WCvMVHW8urw+ryPuqay+QOlGsRcO7 AY40UT0aJN95zPkapFPrJWQFYLk9v4F89HoxyJ8s+n/mqan9P85MpHozgO5EPlGT 4vBnemv6gIxg51Q+lXc8tvlfemQxvz+eZ8rWCFYhIPzmrb/T2hkAc8ObK4dqwDgj JfZfBwPmJDHkzetQMDkbJCbKa/IRukeU1IXK9wzvIew+tgZTBPOikzqn9knh1yH3 pcl7hi2C2JLJF7GW4/5/nGPIv8MfwsER1BOrlR2a3MZyEaZB/kw8LxJMfgFwowIj +mF3JRM2A2HuM8sxfqJzkBFGbnl0qUQOfIHysT19PR615YGULAs= =7nLO -----END PGP SIGNATURE----- --XusqxpXOodgkJo6J--