From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 1BCA03858D32 for ; Sun, 15 Jan 2023 21:47:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BCA03858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id B211B340E71; Sun, 15 Jan 2023 21:47:45 +0000 (UTC) Date: Sun, 15 Jan 2023 16:47:44 -0500 From: Mike Frysinger To: Mark Wielaard Cc: gdb-patches@sourceware.org, Sam James Subject: Re: [PATCH] sim: mn10300: minimize mn10300-sim.h include in sim-main.h Message-ID: References: <20230115202009.149626-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WHy72/Z+4+Y8f/Xo" Content-Disposition: inline In-Reply-To: <20230115202009.149626-1-mark@klomp.org> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --WHy72/Z+4+Y8f/Xo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 15 Jan 2023 21:20, Mark Wielaard wrote: > --- a/sim/mn10300/sim-main.h > +++ b/sim/mn10300/sim-main.h > @@ -38,7 +38,14 @@ mn10300_core_signal ((SD), (CPU), (CIA), (MAP), (NR_BY= TES), (ADDR), (TRANSFER), > #include "sim-fpu.h" > #include "sim-signal.h" > =20 > +/* These datastructures and defines are only used by the igen generated > + support.c, semantics.c, idecode.c and engine.c files. */ > +#if defined(SUPPORT_C) \ > + || defined(SEMANTICS_C) \ > + || defined(IDECODE_C) \ > + || defined(ENGINE_C) > #include "mn10300-sim.h" > +#endif a nifty hack. can you move the sim-fpu.h & sim-signal.h inside this block ? -mike --WHy72/Z+4+Y8f/Xo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmPEdIAACgkQQWM7n+g3 9YEL4Q/+IJjtFBWgiW88zbyZpQ4/0v9eQviJh/lks74KANwvKoiFO0G5/uREW9Cb mxzUZ+7haYZ0pWx967no2t+5f64hP0bOpTxDDRXdNcm9VUlEVv9DXVQ2L+5HrvOj fbNbYpMEeQTs30rkU/QkTD3hPPcR+5zsvtqIWw8nyxMcc4XHsx/ucgE0venr5Mq7 FG8SFoNoq4Wn22n1whA8zIdsE8MlVmbnr426m5ZBURNtpu7MH9JZs9OPFFzNHshq obIbAFVUUuvFBb0Ow924XTiAK3Qr4OEPz83HyUJ+tGFKXM23JOMvH/rc74ZED0S/ 5vsXqwcphtNZ/0Wvxhfx/0VQi+Hb1Q72QM2TtgJNwMQVaUblQA84yaPxgLsfU5tm VtRfIlrkzMRxVCpuyagzJxSokNRSWYgU2JY+JzBsjMJZPwJ4KYklLx14LgvI4qmT 41ZB7AP8pLlSfKPucLqDnnLjMdv9biZxA6PRA7F3bzTiLRgSXAWeC1EnoH7E402w EIGFNT9WbG1tfLo8jQP10SAK+Z2W5ByNmkpglUI1AFTxZ6681hnfioMqn44vIhSf /UINOb6nx7JuNG/j2oC8OZegXiHr6DoysesYGv4cahk2Y2wLfU2vVtt5vh8tUz6R k+OSett9fqmW3tnt8vioiHZK9nkQ25xY77Y90lEjI24FzAfEtDU= =PaFg -----END PGP SIGNATURE----- --WHy72/Z+4+Y8f/Xo--