From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 5B3AA3858C52 for ; Thu, 19 Jan 2023 00:01:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B3AA3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 7AC9F340BE2; Thu, 19 Jan 2023 00:01:25 +0000 (UTC) Date: Wed, 18 Jan 2023 19:01:24 -0500 From: Mike Frysinger To: Mark Wielaard Cc: gdb-patches@sourceware.org, Sam James Subject: Re: [PATCH] sim: mn10300: minimize mn10300-sim.h include in sim-main.h Message-ID: References: <20230115202009.149626-1-mark@klomp.org> <20230118215314.GB6144@gnu.wildebeest.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D4jtGrHdAaGBYDyY" Content-Disposition: inline In-Reply-To: <20230118215314.GB6144@gnu.wildebeest.org> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --D4jtGrHdAaGBYDyY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 18 Jan 2023 22:53, Mark Wielaard wrote: > On Sun, Jan 15, 2023 at 04:47:44PM -0500, Mike Frysinger wrote: > > On 15 Jan 2023 21:20, Mark Wielaard wrote: > > > --- a/sim/mn10300/sim-main.h > > > +++ b/sim/mn10300/sim-main.h > > > @@ -38,7 +38,14 @@ mn10300_core_signal ((SD), (CPU), (CIA), (MAP), (N= R_BYTES), (ADDR), (TRANSFER), > > > #include "sim-fpu.h" > > > #include "sim-signal.h" > > > =20 > > > +/* These datastructures and defines are only used by the igen genera= ted > > > + support.c, semantics.c, idecode.c and engine.c files. */ > > > +#if defined(SUPPORT_C) \ > > > + || defined(SEMANTICS_C) \ > > > + || defined(IDECODE_C) \ > > > + || defined(ENGINE_C) > > > #include "mn10300-sim.h" > > > +#endif > >=20 > > a nifty hack. can you move the sim-fpu.h & sim-signal.h inside this > > block ? >=20 > Sure. That does mean sim/mn10300/{dv-mn103cpu.c,interp.c,op_utils.c} > need to also explicitly include one or both of these files. But I > guess that these explicit includes are the intention. yes, that's the direction we want to go > See attached. OK to push like that? lgtm, thanks -mike --D4jtGrHdAaGBYDyY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmPIiE8ACgkQQWM7n+g3 9YGOmRAA3z7KXOULBl+8azNo7Hf4nVnWTXU4iqgO+nEwBXargfdfbBAZVOyafk44 27s+MSU8YL8G/uAunyBzmfudqkAy7mmsYGyFKp11OMnQkb+J5aR7frV6fLdLTv1t Wjg0pbV+rvQkMDHzpXhbss67vuUNJM/FZeVnywHfP5xOIafiYSLhAES2GyNGFyNV hLBuFyJKXmTrsgAotVVrkaUDiiFTw90gikwd4wwRXejeZo5NzrKUKepyAibnpjjR DyRifD8rl9Vy7/BDm9QwCILnyJRt5KLxTFVqntY4T6FZPubuMqas/es0wsh4cJBt OUzV7QOPD+wzV/OB79YkzLSce428YfNyKdw+O6eoMNCYQrQ+YSS7IdFbVanvyt+6 6D9idVQzuFaXIam6IqvpXVp/VeDoXJxs5c0WVOFwBFHWGIQoOej5M+vcG3ir/Kgb 84ejefUrDqjjy2Lyt3y2s/bc39NU/h2HVXkSg7OC1QLCN9NNS/Rg6rlUZg6q2P5G M2tuhuP8wJ5r0WGgtE0oIhh4p+X/A1wWBG8k6YaoAaRzTet7dtPQ39Kz4MuMLBy6 7kzLeObFyXO28zejgiwNkMipA7/wUVANTFeEVAf1ehyGwJSSPkzhsEuRMjck7oPn AaPeUPh2fGzjSrAVSUucQeRHxx5Jq5DzxGNG00PB44lZ8bUTbMk= =J5+w -----END PGP SIGNATURE----- --D4jtGrHdAaGBYDyY--