From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 3257E3858D38 for ; Mon, 30 Jan 2023 05:25:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3257E3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x433.google.com with SMTP id o18so447117wrj.3 for ; Sun, 29 Jan 2023 21:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=gkaXkSy8x5xKPjJG3n5oqkkO1nW4smLBPS8j2r7nrd4=; b=MZstlUM7zbYUOURWaEPV9jIaLA3yM6qt1S3eI70ze3zHUK77d/AfvdQo4TpFZIHQ3i Nqj02li/SFY7gOxjqE3L6RuuaxT37uEDZTfll2ctZlpa3JcqXre2NtgivIbFNWvvjBeR Yw7zIreraqQ21bkd9Ue752G3AUHklCruoFaemlGC+ZdvPrTiHI5yKvn61abrZ3J6yIJ+ C1TDD8J0XokzEu159iNtm4AzakmNzAGS7ui1de99m/0GYzQllskYMr1re3uc/DyJvrTU BhDErnuvhEvRBmm3C2/qL7MhVsj7EhwLANn3xwuAPDRllN2/Di9KZeEOa09ueFgFEQsN 5Z6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gkaXkSy8x5xKPjJG3n5oqkkO1nW4smLBPS8j2r7nrd4=; b=1JvTIYQij8yGEcpc8OOJeqWYlN4p+ut5I4oMh6SYQe5cnegVWyksV1aBVHgXJoyrLv ScYn9HtEZfO5r/8DKh9Z0hzkmedIEOQM2oJ7XfqOEwc/voyyxVbnxX61/OWMEOqffWYY aX6t1+j39d+Xsi5zbxfayVfIFkhwdQHJWm24US+kXF48O+4VOP/DY2myZid+rOGD6la6 JRVGg/Apv7hj+8IQyPnruxpkLpSkxzL9ck+w1uf1AGC40n2gsSo3dUgqMPnLyn1Z3mm6 BRvUHcEFdl7PtDUPVg66ecz6MUmaFmaz0Prm9AA8Ise+A1wJmhZignPpsVGZrBAFBR+A 4NyA== X-Gm-Message-State: AO0yUKWmg674fsy7SaVl7HXVFRg2ueOKfHWaPo+RXnIidirzrZF2jJSi 5IawrGx6t0SDxMyHQvmWZei56uC/25mAymjSng== X-Google-Smtp-Source: AK7set9pZhZDkIzJI974F4E6hNAfkySxtfk/Uw3xwAnQva+XoVej/tZjPSWkaqlegutKLPLjHtTfSg== X-Received: by 2002:a05:6000:11ce:b0:2bf:bd69:234b with SMTP id i14-20020a05600011ce00b002bfbd69234bmr13460433wrx.32.1675056308007; Sun, 29 Jan 2023 21:25:08 -0800 (PST) Received: from takamaka.gnat.com (lfbn-reu-1-488-54.w92-130.abo.wanadoo.fr. [92.130.77.54]) by smtp.gmail.com with ESMTPSA id b11-20020adfd1cb000000b002bcaa47bf78sm11418852wrd.26.2023.01.29.21.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 21:25:07 -0800 (PST) Received: by takamaka.gnat.com (Postfix, from userid 1000) id 4483382775; Sun, 29 Jan 2023 15:52:49 +0400 (+04) Date: Sun, 29 Jan 2023 15:52:49 +0400 From: Joel Brobecker To: Luis Machado Cc: Simon Marchi , Joel Brobecker , Torbjorn SVENSSON , tom@tromey.com, gdb-patches@sourceware.org Subject: Re: GDB 13 release -- 2023-01-21 Update Message-ID: References: <95dc547e-59f8-95b3-903c-138d8842cea0@foss.st.com> <47dff98e-b714-2d72-bc3b-c14c4e0313d0@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DATE_IN_PAST_12_24,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > > > > - With that said, the patch appears to simply add a cache, > > > > so the logic of it all doesn't appear to be extremely > > > > complicated. So I would rate the risk to be low. > > > > > > That's what it seems to me. > > > > > > I think another round of testing would be a good step to make sure there are no hidden bugs. > > My understanding is that the problem was making debugging borderline > > impossible. Or at least, really, really unpleasant. So I think it > > qualifies as a bug fix, and that the benefit is worth the risk. > > Right. Past a short number of frames, unwinding got really really slow. The part that I haven't been clear on is whether this affected everyone on Arm-32bit, or everyone on both Arm and AArch64, or just a subset of the users? Regardless of the above, I agree we can backport. To avoid confusion, can I leave this to you, Luis, to confirm that the two patches I identified previously are the only two patches that need to be backported, and can you backport those for us, with a round of testing if you haven't done so already, just to double-check? For the record, those patches were: commit d72ba177c85f2ad18d0dcabdd8844532c9acb819 Author: Torbjörn SVENSSON Date: Thu Nov 17 12:17:53 2022 +0100 Subject: gdb: dwarf2 generic implementation for caching function data ... and ... commit 5cf11483141a58314834653003e49709b47822d5 Author: Torbjörn SVENSSON Date: Thu Nov 17 12:18:20 2022 +0100 Subject: gdb/arm: Use new dwarf2 function cache Thank you! -- Joel