From: Shahab Vahedi <shahab.vahedi@gmail.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, Shahab Vahedi <shahab@synopsys.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH] gdb: Use correct feature in tdesc-regs for ARC
Date: Tue, 26 Jan 2021 12:02:19 +0100 [thread overview]
Message-ID: <YA/2u05rKdfSWUxH@gmail.com> (raw)
In-Reply-To: <20210126091736.GG265215@embecosm.com>
Hi Andrew,
On Tue, Jan 26, 2021 at 09:17:36AM +0000, Andrew Burgess wrote:
> * Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org> [2021-01-26 00:02:44 +0100]:
>
> > "arc*-*-*" {
> > set architecture "arc:ARCv2"
> > - set core-regs {arc-v2.xml}
> > + set regdir "arc/"
> > + set core-regs {core-v2.xml aux-v2.xml}
>
> Maybe I'm either going crazy, or really don't understand this test (do
> please correct me), but the contents of gdb/features/arc/ on current
> master are:
>
> $ ls gdb/features/arc/
> v1-aux.c v1-aux.xml v1-core.c v1-core.xml v2-aux.c v2-aux.xml v2-core.c v2-core.xml
>
> So shouldn't this be:
>
> set core-regs {v2-core.xml v2-aux.xml}
>
> But for a change to only one test file, surely this was tested, right?
> So how was it passing for you?
You're absolutely right! This was a snafu on my side. This fix happened
chronologically before ARC's XML feature patch [1] evolve to its final form.
I've had marked the previously submitted patch [2] as "ready for upstream"
in my backlog commits and did not execute the tests again. I sincerely
apologise for that.
The new patch is submitted again [3] along with the test results in the
commit message.
[1] arc: Add ARCv2 XML target along with refactoring
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=995d3a197d7a
[2] [PATCH] gdb: Use correct feature in tdesc-regs for ARC
https://sourceware.org/pipermail/gdb-patches/2021-January/175458.html
[3] [PATCH v2] gdb: Use correct feature in tdesc-regs for ARC
https://sourceware.org/pipermail/gdb-patches/2021-January/175476.html
Cheers,
Shahab
next prev parent reply other threads:[~2021-01-26 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 23:02 Shahab Vahedi
2021-01-26 9:17 ` Andrew Burgess
2021-01-26 11:02 ` Shahab Vahedi [this message]
2021-01-26 10:47 ` [PATCH v2] " Shahab Vahedi
2021-02-04 19:35 ` [PUSHED] " Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA/2u05rKdfSWUxH@gmail.com \
--to=shahab.vahedi@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).