From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 57EFB3857821 for ; Tue, 26 Jan 2021 11:01:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 57EFB3857821 Received: by mail-lf1-x134.google.com with SMTP id v24so22174876lfr.7 for ; Tue, 26 Jan 2021 03:01:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Lb1fhBap+wrTzWB24Ka2iwYrzYm6wuofocY/6LdaQaw=; b=VbixIGnX8UVjaAzUuixX8sbNT6N1cCLAhsQ6j4R+6jm6Xoj9JgXPG7rSRq8/szdz1w j80N5ha/97El1w6Cfq29sC9X9uvZztbrZnuBIq3GNTd2UHNtuP6sgDGwIqSI2BI5gL50 cFQVgTZwHpXI9XGwlpzS/2Ck+TpbMM66h2dGBNlbIMvbhSGpKHyHdBwpnMUOQT7pJZiQ Ej49prz78zLodJbMx6Nsuf0Du0iwUQbQ9GYL2CBlpLqPSiiecPPhXz7+P5sLkn1Bsosf dRvvh2L07P4RsA7JoeDz/biSNc/jFLX5rFvO6tOzwEPLtTqoiJsCx+FY3VI/z8V87Ij5 NwJA== X-Gm-Message-State: AOAM531cojqedk5rVXui2bUYI+wcQOA4UYqrxttljzVFuYY8ekTRatAa ZIMLqsbCH8zQ3tgripVo5f8= X-Google-Smtp-Source: ABdhPJwLiuXnPlxLSCJCgxoPC2/+bJjzKL5Ahx00x9g+0UxUyZuJR0HH/HjHn20R8I/nwD3lZfey3g== X-Received: by 2002:a19:341:: with SMTP id 62mr2325894lfd.500.1611658914061; Tue, 26 Jan 2021 03:01:54 -0800 (PST) Received: from gmail.com ([2a03:1b20:5:f011::10d]) by smtp.gmail.com with ESMTPSA id l15sm2489088lfc.244.2021.01.26.03.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 03:01:53 -0800 (PST) Date: Tue, 26 Jan 2021 12:02:19 +0100 From: Shahab Vahedi To: Andrew Burgess Cc: gdb-patches@sourceware.org, Shahab Vahedi , Francois Bedard Subject: Re: [PATCH] gdb: Use correct feature in tdesc-regs for ARC Message-ID: References: <20210125230244.12445-1-shahab.vahedi@gmail.com> <20210126091736.GG265215@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126091736.GG265215@embecosm.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2021 11:01:56 -0000 Hi Andrew, On Tue, Jan 26, 2021 at 09:17:36AM +0000, Andrew Burgess wrote: > * Shahab Vahedi via Gdb-patches [2021-01-26 00:02:44 +0100]: > > > "arc*-*-*" { > > set architecture "arc:ARCv2" > > - set core-regs {arc-v2.xml} > > + set regdir "arc/" > > + set core-regs {core-v2.xml aux-v2.xml} > > Maybe I'm either going crazy, or really don't understand this test (do > please correct me), but the contents of gdb/features/arc/ on current > master are: > > $ ls gdb/features/arc/ > v1-aux.c v1-aux.xml v1-core.c v1-core.xml v2-aux.c v2-aux.xml v2-core.c v2-core.xml > > So shouldn't this be: > > set core-regs {v2-core.xml v2-aux.xml} > > But for a change to only one test file, surely this was tested, right? > So how was it passing for you? You're absolutely right! This was a snafu on my side. This fix happened chronologically before ARC's XML feature patch [1] evolve to its final form. I've had marked the previously submitted patch [2] as "ready for upstream" in my backlog commits and did not execute the tests again. I sincerely apologise for that. The new patch is submitted again [3] along with the test results in the commit message. [1] arc: Add ARCv2 XML target along with refactoring https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=995d3a197d7a [2] [PATCH] gdb: Use correct feature in tdesc-regs for ARC https://sourceware.org/pipermail/gdb-patches/2021-January/175458.html [3] [PATCH v2] gdb: Use correct feature in tdesc-regs for ARC https://sourceware.org/pipermail/gdb-patches/2021-January/175476.html Cheers, Shahab