From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
 by sourceware.org (Postfix) with ESMTP id 70F543854838
 for <gdb-patches@sourceware.org>; Mon, 18 Jan 2021 18:01:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70F543854838
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id B1821340DE1;
 Mon, 18 Jan 2021 18:01:52 +0000 (UTC)
Date: Mon, 18 Jan 2021 13:01:53 -0500
From: Mike Frysinger <vapier@gentoo.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: testsuite: push $arch out to targets
Message-ID: <YAXNEf6Xoak+sKjB@vapier>
Mail-Followup-To: Andrew Burgess <andrew.burgess@embecosm.com>,
 gdb-patches@sourceware.org
References: <20210117160945.1362-1-vapier@gentoo.org>
 <20210118095201.GN265215@embecosm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210118095201.GN265215@embecosm.com>
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jan 2021 18:01:54 -0000

On 18 Jan 2021 09:52, Andrew Burgess wrote:
> * Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-17 11:09:45 -0500]:
> > This is needed to move to automake & its dejagnu-provided logic,
> > and eventually by the unified sim logic.
> 
> I looked through this patch and I didn't understand what's going on
> here.
> 
> Why do you need to set the global arch in some, but not all tests?

it is being done in all tests.  which ones do you think i skipped ?

> If this needs doing at all, could it not be done in some global location?

the sim ports use a unique subdir for their `run` program.  the tests
need to find that path.  this $arch value is what binds the specific
subdir to the test.

as we do multibuilds, we'll have multiple ports active, so a single
variable won't cut it.  moving it here and out of autotols enables
that.  as we do multitarget, this will help smooth the transition as
we won't have to juggle each arch as it migrates.
-mike