public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] sim: drop dep on configure-gdb
@ 2021-02-28  7:08 Mike Frysinger
  2021-03-03 20:13 ` Tom Tromey
  0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2021-02-28  7:08 UTC (permalink / raw)
  To: gdb-patches

I'm not entirely sure why this is here since the sim doesn't use
anything from the gdb/ dir directly, and the commit that added it
included a bunch more changes and doesn't seem to call out this
dep specifically.
---
 ChangeLog    | 5 +++++
 Makefile.def | 1 -
 Makefile.in  | 1 -
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e9a5611c5e71..2de48a1aa75c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2021-02-28  Mike Frysinger  <vapier@gentoo.org>
+
+	* Makefile.def: Remove all-sim dependency on configure-gdb.
+	* Makefile.in: Regenerated.
+
 2021-02-09  Alan Modra  <amodra@gmail.com>
 
 	* configure.ac: Delete arm*-*-symbianelf* entry.
diff --git a/Makefile.def b/Makefile.def
index b45e580da5b2..0cdf044c5c3e 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -533,7 +533,6 @@ dependencies = { module=all-sim; on=all-libiberty; };
 dependencies = { module=all-sim; on=all-bfd; };
 dependencies = { module=all-sim; on=all-opcodes; };
 dependencies = { module=all-sim; on=all-readline; };
-dependencies = { module=all-sim; on=configure-gdb; };
 
 // Other host modules.
 dependencies = { module=all-fastjar; on=all-zlib; };
diff --git a/Makefile.in b/Makefile.in
index 0a64fc10e5b0..4f82fd0a47fd 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -52381,7 +52381,6 @@ install-strip-sid: maybe-install-strip-tcl
 install-sid: maybe-install-tk
 install-strip-sid: maybe-install-strip-tk
 all-sim: maybe-all-readline
-all-sim: maybe-configure-gdb
 all-fastjar: maybe-all-build-texinfo
 all-libctf: all-libiberty
 all-stage1-libctf: all-stage1-libiberty
-- 
2.30.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] sim: drop dep on configure-gdb
  2021-02-28  7:08 [PATCH] sim: drop dep on configure-gdb Mike Frysinger
@ 2021-03-03 20:13 ` Tom Tromey
  2021-03-04  8:51   ` Mike Frysinger
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2021-03-03 20:13 UTC (permalink / raw)
  To: Mike Frysinger via Gdb-patches

>>>>> "Mike" == Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> writes:

Mike> I'm not entirely sure why this is here since the sim doesn't use
Mike> anything from the gdb/ dir directly, and the commit that added it
Mike> included a bunch more changes and doesn't seem to call out this
Mike> dep specifically.

The top-level build stuff is shared with GCC, so this patch ought to go
there first.  It seems fine though.

Tom

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] sim: drop dep on configure-gdb
  2021-03-03 20:13 ` Tom Tromey
@ 2021-03-04  8:51   ` Mike Frysinger
  2021-03-04  9:58     ` Tom Tromey
  0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2021-03-04  8:51 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

On 03 Mar 2021 13:13, Tom Tromey wrote:
> >>>>> "Mike" == Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Mike> I'm not entirely sure why this is here since the sim doesn't use
> Mike> anything from the gdb/ dir directly, and the commit that added it
> Mike> included a bunch more changes and doesn't seem to call out this
> Mike> dep specifically.
> 
> The top-level build stuff is shared with GCC, so this patch ought to go
> there first.  It seems fine though.

thanks, i wanted to get a gdb/sim review on this as i've never touched
this file before.  i'll take care of pushing it in gcc too.
-mike

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] sim: drop dep on configure-gdb
  2021-03-04  8:51   ` Mike Frysinger
@ 2021-03-04  9:58     ` Tom Tromey
  2021-03-04 16:38       ` Mike Frysinger
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2021-03-04  9:58 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

Mike> thanks, i wanted to get a gdb/sim review on this as i've never touched
Mike> this file before.  i'll take care of pushing it in gcc too.

FAOD you will probably need a separate review there.

Tom

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] sim: drop dep on configure-gdb
  2021-03-04  9:58     ` Tom Tromey
@ 2021-03-04 16:38       ` Mike Frysinger
  0 siblings, 0 replies; 5+ messages in thread
From: Mike Frysinger @ 2021-03-04 16:38 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

On 04 Mar 2021 02:58, Tom Tromey wrote:
> Mike> thanks, i wanted to get a gdb/sim review on this as i've never touched
> Mike> this file before.  i'll take care of pushing it in gcc too.
> 
> FAOD you will probably need a separate review there.

right, i sent it to gcc-patches@
-mike

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-03-04 16:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-28  7:08 [PATCH] sim: drop dep on configure-gdb Mike Frysinger
2021-03-03 20:13 ` Tom Tromey
2021-03-04  8:51   ` Mike Frysinger
2021-03-04  9:58     ` Tom Tromey
2021-03-04 16:38       ` Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).