From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lsix@lancelotsix.com>
Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net
 [IPv6:2001:41d0:801:2000::2400])
 by sourceware.org (Postfix) with ESMTPS id 1DAB0385801A
 for <gdb-patches@sourceware.org>; Fri, 26 Mar 2021 23:56:17 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1DAB0385801A
Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:bc12:e978:8e83:61f8])
 by lndn.lancelotsix.com (Postfix) with ESMTPSA id 71D42818C3;
 Fri, 26 Mar 2021 23:56:15 +0000 (UTC)
Date: Fri, 26 Mar 2021 23:56:13 +0000
From: Lancelot SIX <lsix@lancelotsix.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb-add-index.sh: Remove use of non posix 'local'
Message-ID: <YF50ne8X+InSPj44@Plymouth>
References: <20210326171454.2795-1-lsix@lancelotsix.com>
 <dd510543-99cd-21c7-0c64-6716469522a7@polymtl.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <dd510543-99cd-21c7-0c64-6716469522a7@polymtl.ca>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11
 (lndn.lancelotsix.com [0.0.0.0]); Fri, 26 Mar 2021 23:56:16 +0000 (UTC)
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Mar 2021 23:56:18 -0000

Le Fri, Mar 26, 2021 at 02:39:52PM -0400, Simon Marchi a écrit :
> On 2021-03-26 1:14 p.m., Lancelot SIX via Gdb-patches wrote:
> > While working on gdb-add-index.sh, it appeared that it uses the non
> > POSIX 'local' keyword.  Instead of using local to allow variable
> > shadowing, I rename the local one to avoid name conflicts altogether.
> 
> Thanks, this is OK.  You can also mention in the commit message that it
> gets rid of this shellcheck warning:
> 
> 
> In gdb-add-index.sh line 63:
>     local file="$1"
>     ^--------^ SC2039: In POSIX sh, 'local' is undefined.
> 
> 
> Simon

I have added this info to the commit message and pushed.

Thanks,
Lancelot.