From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (mail.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id CF5143858004
 for <gdb-patches@sourceware.org>; Fri,  9 Apr 2021 00:35:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CF5143858004
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 20C89335C9C;
 Fri,  9 Apr 2021 00:35:25 +0000 (UTC)
Date: Thu, 8 Apr 2021 20:35:23 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 10/10] Do not check for sys/time.h or sys/times.h
Message-ID: <YG+hS02Y4Hj/k0il@vapier>
Mail-Followup-To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20210408203312.2938165-1-tom@tromey.com>
 <20210408203312.2938165-11-tom@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210408203312.2938165-11-tom@tromey.com>
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2021 00:35:27 -0000

On 08 Apr 2021 14:33, Tom Tromey wrote:
> --- a/sim/m4/sim_ac_common.m4
> +++ b/sim/m4/sim_ac_common.m4
>
> +AC_CHECK_HEADERS([unistd.h dnl
> +                  sys/resource.h sys/mman.h dnl
> +                  fcntl.h fpu_control.h dnl
> +                  dlfcn.h sys/stat.h])

is this a standard pattern ?  in other projects i tend to write:
AC_CHECK_HEADERS(m4_flatten([
  ...headers...
])

no need for the inline dnl's.

should also sort the headers while you're here i guess.

otherwise patch looks fine.
-mike