From: Mike Frysinger <vapier@gentoo.org>
To: Luis Machado <luis.machado@linaro.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH,v2][sim,moxie] Fix DTB generation mechanism and build failure
Date: Thu, 8 Apr 2021 12:37:55 -0400 [thread overview]
Message-ID: <YG8xYxw1oODCA+ZH@vapier> (raw)
In-Reply-To: <20210408144010.1334633-1-luis.machado@linaro.org>
On 08 Apr 2021 11:40, Luis Machado wrote:
> -moxie-gdb.dtb: moxie-gdb.dts
> - dtc -O dtb -o moxie-gdb.dtb ${srcdir}/moxie-gdb.dts
> +moxie-gdb.dtb: @MAINTAINER_MODE_TRUE@ moxie-gdb.dts
> + if test "x$(DTC)" != x; then \
> + $(DTC) -O dtb -o moxie-gdb.dtb ${srcdir}/moxie-gdb.dts ; \
needs `|| exit 1` to catch failures
> + $(SHELL) $(srcroot)/move-if-change moxie-gdb.dtb ${srcdir}/moxie-gdb.dtb ; \
same here
> + fi ;
can you add a warning as an else case that the file has not been updated due
to missing dtc program ? and delete this trailing ;
otherwise, lgtm!
-mike
next prev parent reply other threads:[~2021-04-08 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 19:39 [PATCH] [sim,moxie] " Luis Machado
2021-04-07 20:26 ` Mike Frysinger
2021-04-07 20:39 ` Luis Machado
2021-04-07 22:31 ` Mike Frysinger
2021-04-08 14:40 ` Luis Machado
2021-04-08 14:40 ` [PATCH,v2][sim,moxie] " Luis Machado
2021-04-08 16:37 ` Mike Frysinger [this message]
2021-04-08 17:21 ` [PATCH,v3][sim,moxie] " Luis Machado
2021-04-08 17:44 ` Mike Frysinger
2021-04-08 18:03 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG8xYxw1oODCA+ZH@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).