From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id A619F3947411
 for <gdb-patches@sourceware.org>; Thu,  8 Apr 2021 16:37:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A619F3947411
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id A28FC34058A;
 Thu,  8 Apr 2021 16:37:56 +0000 (UTC)
Date: Thu, 8 Apr 2021 12:37:55 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Luis Machado <luis.machado@linaro.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH,v2][sim,moxie] Fix DTB generation mechanism and build
 failure
Message-ID: <YG8xYxw1oODCA+ZH@vapier>
Mail-Followup-To: Luis Machado <luis.machado@linaro.org>,
 gdb-patches@sourceware.org
References: <20210407193929.1251903-1-luis.machado@linaro.org>
 <20210408144010.1334633-1-luis.machado@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210408144010.1334633-1-luis.machado@linaro.org>
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2021 16:37:59 -0000

On 08 Apr 2021 11:40, Luis Machado wrote:
> -moxie-gdb.dtb: moxie-gdb.dts
> -	dtc -O dtb -o moxie-gdb.dtb ${srcdir}/moxie-gdb.dts
> +moxie-gdb.dtb: @MAINTAINER_MODE_TRUE@ moxie-gdb.dts
> +	if test "x$(DTC)" != x; then \
> +	  $(DTC) -O dtb -o moxie-gdb.dtb ${srcdir}/moxie-gdb.dts ; \

needs `|| exit 1` to catch failures

> +	  $(SHELL) $(srcroot)/move-if-change moxie-gdb.dtb ${srcdir}/moxie-gdb.dtb ; \

same here

> +	fi ;

can you add a warning as an else case that the file has not been updated due
to missing dtc program ?  and delete this trailing ;

otherwise, lgtm!
-mike