From: Mike Frysinger <vapier@gentoo.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Add system includes in sim
Date: Thu, 8 Apr 2021 13:43:31 -0400 [thread overview]
Message-ID: <YG9Aw7RqreWqbdLn@vapier> (raw)
In-Reply-To: <20210408164436.2165323-3-tom@tromey.com>
On 08 Apr 2021 10:44, Tom Tromey wrote:
> This updates various parts of the sim to include missing system
> headers. I made the includes unconditional, because other parts of
> the tree are already doing this.
stdlib.h & time.h are fine as they're in C99.
> * func.c: Include sys/time.h.
this one isn't in C99. we seem to sometimes protect against it, but not
always. if we go by gnulib's notes, it seems like we should just assume
it everywhere. wdyt ?
https://www.gnu.org/software/gnulib/manual/html_node/sys_002ftime_002eh.html#sys_002ftime_002eh
-mike
next prev parent reply other threads:[~2021-04-08 17:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 16:44 [PATCH 0/2] Fix some sim warnings Tom Tromey
2021-04-08 16:44 ` [PATCH 1/2] Do not use old-style definitions in sim Tom Tromey
2021-04-08 17:44 ` Mike Frysinger
2021-04-08 16:44 ` [PATCH 2/2] Add system includes " Tom Tromey
2021-04-08 17:43 ` Mike Frysinger [this message]
2021-04-08 18:32 ` Tom Tromey
2021-04-08 18:43 ` Tom Tromey
2021-04-08 19:26 ` Mike Frysinger
2021-04-08 19:30 ` Tom Tromey
2021-04-08 20:12 ` Mike Frysinger
2021-04-08 20:34 ` Tom Tromey
2021-04-08 20:58 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG9Aw7RqreWqbdLn@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).