From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id 4B6B73945C38
 for <gdb-patches@sourceware.org>; Thu,  8 Apr 2021 17:43:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4B6B73945C38
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 8AE62335C9A;
 Thu,  8 Apr 2021 17:43:32 +0000 (UTC)
Date: Thu, 8 Apr 2021 13:43:31 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Add system includes in sim
Message-ID: <YG9Aw7RqreWqbdLn@vapier>
Mail-Followup-To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20210408164436.2165323-1-tom@tromey.com>
 <20210408164436.2165323-3-tom@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210408164436.2165323-3-tom@tromey.com>
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2021 17:43:35 -0000

On 08 Apr 2021 10:44, Tom Tromey wrote:
> This updates various parts of the sim to include missing system
> headers.  I made the includes unconditional, because other parts of
> the tree are already doing this.

stdlib.h & time.h are fine as they're in C99.

> 	* func.c: Include sys/time.h.

this one isn't in C99.  we seem to sometimes protect against it, but not
always.  if we go by gnulib's notes, it seems like we should just assume
it everywhere.  wdyt ?
https://www.gnu.org/software/gnulib/manual/html_node/sys_002ftime_002eh.html#sys_002ftime_002eh
-mike