From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
 by sourceware.org (Postfix) with ESMTP id D382C39551C5
 for <gdb-patches@sourceware.org>; Thu,  8 Apr 2021 20:12:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D382C39551C5
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 9D6DB335D2C;
 Thu,  8 Apr 2021 20:12:44 +0000 (UTC)
Date: Thu, 8 Apr 2021 16:12:43 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Add system includes in sim
Message-ID: <YG9juw+eHHQ+wfXN@vapier>
Mail-Followup-To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20210408164436.2165323-1-tom@tromey.com>
 <20210408164436.2165323-3-tom@tromey.com> <YG9Aw7RqreWqbdLn@vapier>
 <87y2dsk4og.fsf@tromey.com> <YG9YywoTs/2HUJKg@vapier>
 <87lf9sk20m.fsf@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87lf9sk20m.fsf@tromey.com>
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2021 20:12:47 -0000

On 08 Apr 2021 13:30, Tom Tromey wrote:
> >>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
> 
> Mike> On 08 Apr 2021 12:32, Tom Tromey wrote:
> >> >> * func.c: Include sys/time.h.
> >> 
> Mike> this one isn't in C99.  we seem to sometimes protect against it, but not
> Mike> always.  if we go by gnulib's notes, it seems like we should just assume
> Mike> it everywhere.  wdyt ?
> Mike> https://www.gnu.org/software/gnulib/manual/html_node/sys_002ftime_002eh.html#sys_002ftime_002eh
> >> 
> >> Makes sense to me.
> >> 
> >> Also, BFD removed the check for time.h, among other things, in commit
> >> 83c79df86.  If BFD can remove it, I think it's fine.
> 
> Mike> we removed time.h checks in 68ed2854284d415a71efd856a40343f550881ede in sim
> Mike> since it's in C99.  this question is about sys/time.h which is different.
> 
> Sorry, I meant to say sys/time.h there.
> The BFD ChangeLog says:
> 
> 	* configure.ac: Don't check for long long or long double type.
> 	Don't check for alloca.h, limits.h, stddef.h, stdlib.h, string.h,
> 	strings.h, time.h, wchar.h, wctype.h or sys/time.h.  [...]
> 
> So I still think it's fine.

gdb & sim document their expectations (C11/C++11).  i guess we nee to do the
same thing under BFD ?  and include the stuff it expects beyond C11.
-mike