From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (mail.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id 5B4CD3857033
 for <gdb-patches@sourceware.org>; Thu,  8 Apr 2021 20:58:20 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B4CD3857033
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 867D8340D67;
 Thu,  8 Apr 2021 20:58:19 +0000 (UTC)
Date: Thu, 8 Apr 2021 16:58:18 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Add system includes in sim
Message-ID: <YG9uanP8yfoYNpE2@vapier>
Mail-Followup-To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20210408164436.2165323-1-tom@tromey.com>
 <20210408164436.2165323-3-tom@tromey.com> <YG9Aw7RqreWqbdLn@vapier>
 <87y2dsk4og.fsf@tromey.com> <87wntch5wo.fsf@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87wntch5wo.fsf@tromey.com>
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS,
 TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2021 20:58:21 -0000

On 08 Apr 2021 14:34, Tom Tromey wrote:
> >>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
> 
> >>> * func.c: Include sys/time.h.
> Mike> this one isn't in C99.  we seem to sometimes protect against it, but not
> Mike> always.  if we go by gnulib's notes, it seems like we should just assume
> Mike> it everywhere.  wdyt ?
> Mike> https://www.gnu.org/software/gnulib/manual/html_node/sys_002ftime_002eh.html#sys_002ftime_002eh
> 
> Tom> Makes sense to me.
> 
> I'm going to go ahead & check in both of these.

of course, thanks
-mike