From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id 86505385803F
 for <gdb-patches@sourceware.org>; Mon,  5 Apr 2021 17:17:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 86505385803F
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id A4B8F340D46;
 Mon,  5 Apr 2021 17:17:01 +0000 (UTC)
Date: Mon, 5 Apr 2021 13:17:01 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Dimitar Dimitrov <dimitar@dinux.eu>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] sim: testsuite: calculate $arch from $subdir
Message-ID: <YGtGDXkonhUn5Y47@vapier>
Mail-Followup-To: Dimitar Dimitrov <dimitar@dinux.eu>,
 gdb-patches@sourceware.org
References: <20210404143538.14995-1-vapier@gentoo.org>
 <5328944.Q7PVtjR6cZ@tpdeb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5328944.Q7PVtjR6cZ@tpdeb>
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2021 17:17:03 -0000

On 05 Apr 2021 19:31, Dimitar Dimitrov wrote:
> From 6f0fb28ff86acc17b5038978cc42144ffa5a5cb4 Mon Sep 17 00:00:00 2001
> From: Dimitar Dimitrov <dimitar@dinux.eu>
> Date: Mon, 5 Apr 2021 19:21:35 +0300
> Subject: [PATCH] sim: Add bfd include path for common testsuite tools
> 
> On my Fedora33 host this patch fixes the following "make check-sim"
> errors for both pru cross target, and native x86_64:
> 
> In file included from ../../../binutils/sim/common/sim-basics.h:131,
>                  from testsuite/common/bits32m0.c:13:../../../binutils/sim/../include/gdb/callback.h:55:10: fatal error: bfd.h: No such file or directory
>    55 | #include "bfd.h"
>       |          ^~~~~~~

i'm guessing you don't have libbfd installed in your host distro already ?
i do which is why i think i missed this.

>  %C%_CPPFLAGS = \
>  	-I$(srcdir)/common \
> -	-I$(srcroot)/include
> +	-I$(srcroot)/include \
> +	-I../bfd

this looks fine.  i'm not sure it's super kosher since it's technically,
mixing host & target headers, but i don't think we have much choice at
this point.
-mike