Re: [PATCH] sim/m32c: fix memory leaks in opc2c

[Mike Frysinger <vapier@gentoo.org>]

On 06 Apr 2021 09:28, Simon Marchi via Gdb-patches wrote:
> On 2021-04-06 6:41 a.m., Mike Frysinger wrote:
> > On 05 Apr 2021 21:36, Simon Marchi via Gdb-patches wrote:
> >> Although I'm always in favor of using C++ for just not having to think
> >> about free-ing stuff.
> > 
> > right, and we don't have to debate this :).  i can let it go for the sake
> > of the gains with the better language.
> > 
> > NB: this would only apply to build-time tools like opc2c.
> > 
> > to be clear, if you want to take on changing these tools to C++, i'd be
> > more than happy to help review.  but if you feel that's too much to take
> > on, we can do the aforementioned conditional frees.
> 
> I might try to take it on as a side project, but this is clearly too big
> as an immediate solution.

that's totally understandable

> What do you think of the patch below that
> sets ASAN_OPTIONS while running the tools?

i'm not keen on pushing it in this direction exactly.  it would mean every
caller would have to update & keep track.

i think you could define an IGEN variable in common/Make-common.in and change
all callers over to that.  then that would be the only place you'd have to add
any sanitizer related variables to.
-mike