From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
 by sourceware.org (Postfix) with ESMTP id 1531B3844025
 for <gdb-patches@sourceware.org>; Sun,  2 May 2021 04:50:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1531B3844025
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 25AF6335D74;
 Sun,  2 May 2021 04:50:39 +0000 (UTC)
Date: Sun, 2 May 2021 00:50:38 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gnulib: import getline
Message-ID: <YI4vnmuuIgygkJ0V@vapier>
Mail-Followup-To: Simon Marchi <simon.marchi@polymtl.ca>,
 gdb-patches@sourceware.org
References: <20210501220936.30972-1-vapier@gentoo.org>
 <533969a7-d2fe-cdbd-40dc-e77eab30a469@polymtl.ca>
 <YI32WdVwRu0lzxNC@vapier>
 <9b1cfe9d-2366-f626-f555-3ee5a99cddbc@polymtl.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9b1cfe9d-2366-f626-f555-3ee5a99cddbc@polymtl.ca>
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 02 May 2021 04:50:41 -0000

On 01 May 2021 20:49, Simon Marchi via Gdb-patches wrote:
> On 2021-05-01 8:46 p.m., Mike Frysinger wrote:
> > On 01 May 2021 20:39, Simon Marchi wrote:
> >> On 2021-05-01 6:09 p.m., Mike Frysinger via Gdb-patches wrote:
> >>> We use getline in sim today which breaks on older systems that are
> >>> compliant with the latest POSIX standard.
> >>
> >> I can't really parse that sentence.  Using getline doesn't work on older
> >> systems, because those older systems are compliant with the latest POSIX
> >> standard?  Huh?  Wouldn't being compliant with the latest POSIX standard
> >> be a good thing?
> > 
> > sorry, meant "not compliant".  getline is in POSIX, but not all targets
> > support it.  e.g. Windows (mingw) omit it.
> 
> Ah ok, that makes more sense, thanks.  Still, please mention the
> specific platform in the commit message.  I always understand better
> with a concrete example.

sure, that's np.

gnulib: import getline

We use getline in sim today which breaks on older systems that are
not compliant with the latest POSIX standard.  For example, Windows
(mingw) omits getline so we fail to build there.