public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] Fix LD_PRELOAD=/usr/lib64/libasan.so.6 gdb
Date: Sun, 2 May 2021 15:34:58 +0200	[thread overview]
Message-ID: <YI6qgpsVZt991g9E@host1.jankratochvil.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Hi,

AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete) on 0x613000000040
https://bugzilla.redhat.com/show_bug.cgi?id=1510413

The gdb binary had so far on Fedora 34 x86_64:

                 U operator delete[](void*)
                 U operator delete[](void*, unsigned long)
                 U operator delete(void*, unsigned long)

While now there are defined all these - but IMO it is a bit unpredictable
which will be used in the future:

00000000000000c0 T operator delete[](void*)
00000000000000d0 T operator delete[](void*, std::nothrow_t const&)
00000000000000e0 T operator delete[](void*, unsigned long)
0000000000000090 T operator delete(void*)
00000000000000a0 T operator delete(void*, std::nothrow_t const&)
00000000000000b0 T operator delete(void*, unsigned long)


Jan

[-- Attachment #2: 1 --]
[-- Type: text/plain, Size: 1119 bytes --]

gdbsupport/
2021-05-02  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* new-op.cc (opertor delete 6x): New.

diff --git a/gdbsupport/new-op.cc b/gdbsupport/new-op.cc
index 5ab19621a43..f70d3ef191d 100644
--- a/gdbsupport/new-op.cc
+++ b/gdbsupport/new-op.cc
@@ -92,4 +92,44 @@ operator new[] (std::size_t sz, const std::nothrow_t&) noexcept
 {
   return ::operator new (sz, std::nothrow);
 }
+
+/* Define also operators delete as one can LD_PRELOAD=libasan.so.*
+   without recompiling the program with -fsanitize=address . */
+
+void
+operator delete (void *p)
+{
+  free (p);
+}
+
+void
+operator delete (void *p, const std::nothrow_t&) noexcept
+{
+  return ::operator delete (p);
+}
+
+void
+operator delete (void *p, std::size_t) noexcept
+{
+  return ::operator delete (p, std::nothrow);
+}
+
+void
+operator delete[] (void *p)
+{
+  return ::operator delete (p);
+}
+
+void
+operator delete[] (void *p, const std::nothrow_t&) noexcept
+{
+  return ::operator delete (p, std::nothrow);
+}
+
+void
+operator delete[] (void *p, std::size_t) noexcept
+{
+  return ::operator delete[] (p, std::nothrow);
+}
+
 #endif

             reply	other threads:[~2021-05-02 13:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02 13:34 Jan Kratochvil [this message]
2021-05-02 13:39 ` Simon Marchi
2021-05-02 13:56   ` Jan Kratochvil
2021-05-02 14:30     ` Simon Marchi
2021-05-02 14:41       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YI6qgpsVZt991g9E@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).