From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
 by sourceware.org (Postfix) with ESMTP id 263B1385802A
 for <gdb-patches@sourceware.org>; Thu, 22 Apr 2021 03:24:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 263B1385802A
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 64E8B34110B;
 Thu, 22 Apr 2021 03:23:59 +0000 (UTC)
Date: Wed, 21 Apr 2021 23:23:58 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Jim Wilson <jimw@sifive.com>
Cc: gdb-patches@sourceware.org, Kito Cheng <kito.cheng@gmail.com>
Subject: Re: [PATCH 09/24] RISC-V sim: Fix syscall fallback.
Message-ID: <YIDsTgmqt1sCAcgQ@vapier>
Mail-Followup-To: Jim Wilson <jimw@sifive.com>, gdb-patches@sourceware.org,
 Kito Cheng <kito.cheng@gmail.com>
References: <20210417175831.16413-1-jimw@sifive.com>
 <20210417175831.16413-10-jimw@sifive.com>
 <CAFyWVaZaY3TfMMHbo4cUtt8oA7HgNEysM_febDP-tAVULzAJsA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFyWVaZaY3TfMMHbo4cUtt8oA7HgNEysM_febDP-tAVULzAJsA@mail.gmail.com>
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2021 03:24:01 -0000

On 21 Apr 2021 16:38, Jim Wilson wrote:
> This one is missing a review.

there's a lot to unpack in this series :).  i figured we'd merge the ones we
def agree on, then respin the series with the ones left.  it makes it a bit
easier to iterate when there's fewer things to look at all at once, both in
terms of scope, and in terms of patch count.

i'm hoping we can avoid forking the syscall handling logic by implementing all
the syscalls you want in the common code, thus this particular patch wouldn't
be necessary.  i'm not 100% confident we can get there, but i think it's worth
trying.
-mike