From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (dev.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id 675E7395C41A
 for <gdb-patches@sourceware.org>; Tue,  4 May 2021 19:49:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 675E7395C41A
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 1E58433BE23;
 Tue,  4 May 2021 19:49:22 +0000 (UTC)
Date: Tue, 4 May 2021 15:49:21 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gnulib: import getline
Message-ID: <YJGlQRWKMTZVMQUJ@vapier>
Mail-Followup-To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
References: <20210501220936.30972-1-vapier@gentoo.org>
 <533969a7-d2fe-cdbd-40dc-e77eab30a469@polymtl.ca>
 <YI32WdVwRu0lzxNC@vapier>
 <9b1cfe9d-2366-f626-f555-3ee5a99cddbc@polymtl.ca>
 <YI4vnmuuIgygkJ0V@vapier> <874kfituax.fsf@tromey.com>
 <YJGIZWce9Wi7aCFC@vapier> <87im3ys3wz.fsf@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87im3ys3wz.fsf@tromey.com>
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 04 May 2021 19:49:26 -0000

On 04 May 2021 13:19, Tom Tromey wrote:
> >> I saw this build problem internally at AdaCore today, so I appreciate
> >> the quick fix.
> 
> Mike> which subdir & target are you seeing issues with ?  is it sim on Windows ?
> Mike> or is it some other combo ?
> 
> It is a Windows build targeting ARM, and I get:
> 
> ../../../src/sim/arm/../common/sim-hw.c:153:29: warning: implicit declaration of function 'getline' [-Wimplicit-function-declaration]
> 
> and
> 
> [...] ld.exe: libsim.a(sim-hw.o):sim-hw.c:(.text+0x2ae): undefined reference to `getline'

this patch is required, but isn't sufficient, to fix this problem.  i've been
hacking on it a bit.  the sim hasn't used gnulib before, so still need to have
it integrate that dir.

in the meantime, --disable-sim-hardware should fix the build by skipping the
new code that uses getline.
-mike