From: Mike Frysinger <vapier@gentoo.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: add ../config/pkg.m4 in acinclude.m4
Date: Sun, 9 May 2021 16:00:20 -0400 [thread overview]
Message-ID: <YJg/VEucobuqW9X0@vapier> (raw)
In-Reply-To: <20210509012432.1154603-1-simon.marchi@polymtl.ca>
On 08 May 2021 21:24, Simon Marchi via Gdb-patches wrote:
> Since commit adeab0c5b33f ("config/debuginfod: do not include pkg.m4
> directly"), it no longer works to re-generate the autoconf stuff in GDB
> without passing "-I ../config":
>
> $ autoreconf -f
> configure.ac:161: error: possibly undefined macro: AC_MSG_ERROR
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> configure.ac:329: error: possibly undefined macro: AC_MSG_WARN
> configure.ac:409: error: possibly undefined macro: AC_DEFINE
> autoreconf: /opt/autostuff/2.69/bin/autoconf failed with exit status: 1
>
> The reason is: since that commit, the PKG_CHECK_MODULES macro is not
> found. When passing "-I ../config" to the autoconf tools, then it's
> found. But if I understand correctly, the reason why we have all these
> includes in acinclude.m4 is to avoid having to specify that, to make the
> default invocation without special arguments "just work".
how about this instead ? i can run `aclocal && autoconf` with this.
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -18,9 +18,8 @@ dnl along with this program. If not, see <http://www.gnu.org/licenses/>.
dnl Process this file with autoconf to produce a configure script.
-m4_include(../config/debuginfod.m4)
-
AC_INIT
+AC_CONFIG_MACRO_DIRS([../config])
AC_CONFIG_SRCDIR([main.c])
AC_CONFIG_HEADERS(config.h:config.in, [echo > stamp-h])
AM_MAINTAINER_MODE
-mike
next prev parent reply other threads:[~2021-05-09 20:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 1:24 Simon Marchi
2021-05-09 20:00 ` Mike Frysinger [this message]
2021-05-10 0:16 ` Simon Marchi
2021-05-10 1:14 ` Mike Frysinger
2021-05-10 1:32 ` Simon Marchi
2021-05-10 13:25 ` Tom Tromey
2021-05-10 22:36 ` Mike Frysinger
2021-06-15 5:44 ` [PATCH] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS Mike Frysinger
2021-06-17 2:30 ` Simon Marchi
2021-06-17 4:21 ` Mike Frysinger
2021-06-17 14:43 ` Simon Marchi
2021-06-18 4:38 ` Mike Frysinger
2021-06-18 13:22 ` Simon Marchi
2021-06-23 9:38 ` Pedro Alves
2021-06-23 22:26 ` Mike Frysinger
2021-06-24 18:45 ` Pedro Alves
2021-06-18 14:03 ` [PATCH v2] " Mike Frysinger
2021-06-20 0:48 ` Simon Marchi
2021-06-20 2:10 ` Mike Frysinger
2021-06-20 2:17 ` Simon Marchi
2021-06-20 2:22 ` [PATCH v3] " Mike Frysinger
2021-06-20 2:46 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJg/VEucobuqW9X0@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).