From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 7BF10385E44A for ; Sun, 9 May 2021 20:00:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7BF10385E44A Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id B1E31335C9F; Sun, 9 May 2021 20:00:23 +0000 (UTC) Date: Sun, 9 May 2021 16:00:20 -0400 From: Mike Frysinger To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: add ../config/pkg.m4 in acinclude.m4 Message-ID: Mail-Followup-To: Simon Marchi , gdb-patches@sourceware.org References: <20210509012432.1154603-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210509012432.1154603-1-simon.marchi@polymtl.ca> X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 May 2021 20:00:27 -0000 On 08 May 2021 21:24, Simon Marchi via Gdb-patches wrote: > Since commit adeab0c5b33f ("config/debuginfod: do not include pkg.m4 > directly"), it no longer works to re-generate the autoconf stuff in GDB > without passing "-I ../config": > > $ autoreconf -f > configure.ac:161: error: possibly undefined macro: AC_MSG_ERROR > If this token and others are legitimate, please use m4_pattern_allow. > See the Autoconf documentation. > configure.ac:329: error: possibly undefined macro: AC_MSG_WARN > configure.ac:409: error: possibly undefined macro: AC_DEFINE > autoreconf: /opt/autostuff/2.69/bin/autoconf failed with exit status: 1 > > The reason is: since that commit, the PKG_CHECK_MODULES macro is not > found. When passing "-I ../config" to the autoconf tools, then it's > found. But if I understand correctly, the reason why we have all these > includes in acinclude.m4 is to avoid having to specify that, to make the > default invocation without special arguments "just work". how about this instead ? i can run `aclocal && autoconf` with this. --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -18,9 +18,8 @@ dnl along with this program. If not, see . dnl Process this file with autoconf to produce a configure script. -m4_include(../config/debuginfod.m4) - AC_INIT +AC_CONFIG_MACRO_DIRS([../config]) AC_CONFIG_SRCDIR([main.c]) AC_CONFIG_HEADERS(config.h:config.in, [echo > stamp-h]) AM_MAINTAINER_MODE -mike