From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id DFEE4385803D for ; Tue, 25 May 2021 23:10:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DFEE4385803D Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id C5F3F340E06; Tue, 25 May 2021 23:10:00 +0000 (UTC) Date: Tue, 25 May 2021 19:09:59 -0400 From: Mike Frysinger To: Yoshinori Sato Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/2] sim: h8300 Fixed different behavior in preinc/predec. Message-ID: Mail-Followup-To: Yoshinori Sato , gdb-patches@sourceware.org References: <20210521141655.68398-1-ysato@users.sourceforge.jp> <20210525141016.91316-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210525141016.91316-1-ysato@users.sourceforge.jp> X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 May 2021 23:10:03 -0000 On 25 May 2021 23:10, Yoshinori Sato wrote: just nits. looks fine otherwise, although i'm no h8300 expert. > + case OP_PREINC: > + if (OP_KIND(dst->opcode) == O_MOV) space before the ( > + case X (OP_REG_DEC, SB): /* Register direct, affected decrement byte. */ > + *val = GET_B_REG (rn) - 1; > + break; > + case X (OP_REG_DEC, SW): /* Register direct, affected decrement word. */ > + *val = GET_W_REG (rn) - 2; > + break; > + case X (OP_REG_DEC, SL): /* Register direct, affected decrement long. */ > + *val = GET_L_REG (rn) - 4; > + break; > + case X (OP_REG_INC, SB): /* Register direct, affected increment byte. */ > + *val = GET_B_REG (rn) + 1; > + break; > + case X (OP_REG_INC, SW): /* Register direct, affected increment word. */ > + *val = GET_W_REG (rn) + 2; > + break; > + case X (OP_REG_INC, SL): /* Register direct, affected increment long. */ > + *val = GET_L_REG (rn) + 4; > + break; 2 spaces after those . in the comment -mike