From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 696E83857C6F for ; Sat, 22 May 2021 01:46:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 696E83857C6F Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 368AB340C9A; Sat, 22 May 2021 01:46:34 +0000 (UTC) Date: Fri, 21 May 2021 21:46:33 -0400 From: Mike Frysinger To: Faraz Shahbazker Cc: gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu Subject: Re: [PATCH 4/5] sim: mips: Add simulator support for mips32r6/mips64r6 Message-ID: Mail-Followup-To: Faraz Shahbazker , gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu References: <20210520074554.1465327-1-fshahbazker@wavecomp.com> <20210520074554.1465327-5-fshahbazker@wavecomp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210520074554.1465327-5-fshahbazker@wavecomp.com> X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 May 2021 01:46:37 -0000 On 20 May 2021 13:15, Faraz Shahbazker wrote: > 2021-05-19 Ali Lown > Andrew Bennett > Dragan Mladjenovic > Faraz Shahbazker i assume everyone has FSF papers in place ? i can't provide too much substantive review on the ISA stuff here. > --- a/sim/mips/cp1.c > +++ b/sim/mips/cp1.c > > +unsigned64 > +fp_classify(sim_cpu *cpu, > > +int > +fp_rint(sim_cpu *cpu, > > +unsigned64 > +fp_min(sim_cpu *cpu, > > +unsigned64 > +fp_max(sim_cpu *cpu, > > +unsigned64 > +fp_mina(sim_cpu *cpu, > > +unsigned64 > +fp_maxa(sim_cpu *cpu, > > unsigned64 > fp_madd(sim_cpu *cpu, > > unsigned64 > fp_msub(sim_cpu *cpu, missing space before the ( should these (and others in this file) be static ? they aren't namespaced. > +unsigned64 > +fp_fmsub (sim_cpu* cpu, shoul be "sim_cpu *cpu". comes up a few times in here. > --- a/sim/mips/interp.c > +++ b/sim/mips/interp.c > > /* Load a word from memory. */ > +#define MIPSR6_P(abfd) \ > + ((elf_elfheader (abfd)->e_flags & EF_MIPS_ARCH) == E_MIPS_ARCH_32R6 \ > + || (elf_elfheader (abfd)->e_flags & EF_MIPS_ARCH) == E_MIPS_ARCH_64R6) define should be before the comment > --- a/sim/mips/mips.igen > +++ b/sim/mips/mips.igen > > +:function:::void:signal_if_cti:instruction_word instr > +{ > + unsigned32 maj = (instr & 0xfc000000) >> 26; > + unsigned32 special = instr & 0x3f; > + if((maj & 0x3e) == 0x06 /* Branch/Jump */ space after "if" > --- a/sim/mips/sim-main.h > +++ b/sim/mips/sim-main.h > > +static const int sim_fpu_class_mips_mapping[] = { shouldn't put these in the header > diff --git a/sim/testsuite/mips/utils-r6.s b/sim/testsuite/mips/utils-r6.s > new file mode 100644 > index 00000000000..e69de29bb2d it's an empty file ? -mike