public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: John Baldwin <jhb@FreeBSD.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] sim: dv-sockser: enable for mingw targets too
Date: Tue, 8 Jun 2021 16:58:54 -0400	[thread overview]
Message-ID: <YL/aDk3vAUHPWqQX@vapier> (raw)
In-Reply-To: <3950ad01-f688-8425-b378-c86d113d4a0e@FreeBSD.org>

On 08 Jun 2021 08:43, John Baldwin wrote:
> On 6/7/21 10:10 PM, Mike Frysinger via Gdb-patches wrote:
> > We have enough functionality from gnulib now to build sockser on
> > all platforms.
> > ---
> >   sim/common/dv-sockser.c          |  6 +++++-
> >   sim/m4/sim_ac_option_hardware.m4 | 16 +++++-----------
> >   2 files changed, 10 insertions(+), 12 deletions(-)
> > 
> > diff --git a/sim/common/dv-sockser.c b/sim/common/dv-sockser.c
> > index 7f1cf798e4b9..f1ef22a53a8e 100644
> > --- a/sim/common/dv-sockser.c
> > +++ b/sim/common/dv-sockser.c
> > @@ -43,7 +43,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> >   #include <sys/socket.h>
> >   
> >   #ifndef __CYGWIN32__
> > -#include <netinet/tcp.h>
> > +//#include <netinet/tcp.h>
> >   #endif
> >   
> >   #include "sim-assert.h"
> 
> This hunk looks like a temporary testing change?  Did you mean to remove the header
> entirely?

err, yeah, i thought i finished that.  i meant to take a closer look to see why
we're even including it in the first place.  thanks.
-mike

  reply	other threads:[~2021-06-08 20:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  5:10 [PATCH 1/3] gnulib: import various network functions Mike Frysinger
2021-06-08  5:10 ` [PATCH 2/3] sim: start unifying portability shims Mike Frysinger
2021-06-08  5:10 ` [PATCH 3/3] sim: dv-sockser: enable for mingw targets too Mike Frysinger
2021-06-08 15:43   ` John Baldwin
2021-06-08 20:58     ` Mike Frysinger [this message]
2021-09-04  7:41 ` [PATCH 1/3] gnulib: import various network functions Mike Frysinger
2021-09-07 14:49 ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YL/aDk3vAUHPWqQX@vapier \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).