From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (mail.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id 6AEF8386FC2D
 for <gdb-patches@sourceware.org>; Tue,  8 Jun 2021 20:58:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6AEF8386FC2D
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 52714335DB7;
 Tue,  8 Jun 2021 20:58:56 +0000 (UTC)
Date: Tue, 8 Jun 2021 16:58:54 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: John Baldwin <jhb@FreeBSD.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] sim: dv-sockser: enable for mingw targets too
Message-ID: <YL/aDk3vAUHPWqQX@vapier>
Mail-Followup-To: John Baldwin <jhb@FreeBSD.org>,
	gdb-patches@sourceware.org
References: <20210608051036.24813-1-vapier@gentoo.org>
 <20210608051036.24813-3-vapier@gentoo.org>
 <3950ad01-f688-8425-b378-c86d113d4a0e@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3950ad01-f688-8425-b378-c86d113d4a0e@FreeBSD.org>
X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jun 2021 20:59:03 -0000

On 08 Jun 2021 08:43, John Baldwin wrote:
> On 6/7/21 10:10 PM, Mike Frysinger via Gdb-patches wrote:
> > We have enough functionality from gnulib now to build sockser on
> > all platforms.
> > ---
> >   sim/common/dv-sockser.c          |  6 +++++-
> >   sim/m4/sim_ac_option_hardware.m4 | 16 +++++-----------
> >   2 files changed, 10 insertions(+), 12 deletions(-)
> > 
> > diff --git a/sim/common/dv-sockser.c b/sim/common/dv-sockser.c
> > index 7f1cf798e4b9..f1ef22a53a8e 100644
> > --- a/sim/common/dv-sockser.c
> > +++ b/sim/common/dv-sockser.c
> > @@ -43,7 +43,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> >   #include <sys/socket.h>
> >   
> >   #ifndef __CYGWIN32__
> > -#include <netinet/tcp.h>
> > +//#include <netinet/tcp.h>
> >   #endif
> >   
> >   #include "sim-assert.h"
> 
> This hunk looks like a temporary testing change?  Did you mean to remove the header
> entirely?

err, yeah, i thought i finished that.  i meant to take a closer look to see why
we're even including it in the first place.  thanks.
-mike