Re: [PATCH] Use is/is not to check for None in python.

[Mike Frysinger <vapier@gentoo.org>]

On 07 Jun 2021 23:50, Lancelot SIX via Gdb-patches wrote:
> While reviewing a patch sent to the mailing list, I noticed there are few
> places where python code checks if a variable is 'None' or not by using the
> comparison operators '==' and '!='.  PEP8[1], which is used as coding standard
> in GDB coding standards, recommends using 'is' / 'is not' when comparing to a
> singleton such as 'None'.

this is correct, so all the changes look fine.  but i wonder if we couldn't
make many more pythonic by treating them as bools.  for example:

> --- a/gdb/testsuite/gdb.python/py-framefilter-invalidarg.py
> +++ b/gdb/testsuite/gdb.python/py-framefilter-invalidarg.py
> @@ -28,7 +28,7 @@ class Reverse_Function(FrameDecorator):
>  
>      def function(self):
>          fname = str(self.fobj.function())
> -        if fname == None or fname == "":
> +        if fname is None or fname == "":

this is simply:
	if not fname:
-mike